You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by merlimat <gi...@git.apache.org> on 2017/05/15 23:05:25 UTC
[GitHub] bookkeeper pull request #156: BOOKKEEPER-1055: Optimize handling of masterKe...
GitHub user merlimat opened a pull request:
https://github.com/apache/bookkeeper/pull/156
BOOKKEEPER-1055: Optimize handling of masterKey in case it is empty
On each request client and bookies are exchanging the ledger masterKey, which is a 20 bytes MAC digest of the ledger password.
For each request there is a considerable overhead in allocating byte arrays when parsing the add/read requests.
If the client is a passing an empty password, we should optimize the data path to skip all allocations (related to the masterKey) and instead rely on a static byte array.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merlimat/bookkeeper empty-password
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/156.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #156
----
commit 33ed98a7653ca82eb2d25cafbad51f6b6fa0dac7
Author: Matteo Merli <mm...@yahoo-inc.com>
Date: 2015-05-11T03:59:41Z
BOOKKEEPER-1055: Optimize handling of masterKey in case it is empty
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #156: BOOKKEEPER-1055: Optimize handling of masterKey in ca...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/156
I was trying to merge, but FindBugs check failed,
@merlimat can you fix the warnings ?
```
[INFO] BugInstance size is 3
[INFO] Error size is 0
[INFO] Total bugs: 3
[INFO] new org.apache.bookkeeper.client.MacDigestManager(long, byte[]) may expose internal representation by storing an externally mutable object into MacDigestManager.passwd [org.apache.bookkeeper.client.MacDigestManager] At MacDigestManager.java:[line 63] EI_EXPOSE_REP2
[INFO] org.apache.bookkeeper.client.MacDigestManager.DIGEST_ALGORITHM isn't final but should be [org.apache.bookkeeper.client.MacDigestManager] At MacDigestManager.java:[line 38] MS_SHOULD_BE_FINAL
[INFO] org.apache.bookkeeper.client.MacDigestManager.KEY_ALGORITHM isn't final but should be [org.apache.bookkeeper.client.MacDigestManager] At MacDigestManager.java:[line 39] MS_SHOULD_BE_FINAL
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #156: BOOKKEEPER-1055: Optimize handling of masterKey in ca...
Posted by merlimat <gi...@git.apache.org>.
Github user merlimat commented on the issue:
https://github.com/apache/bookkeeper/pull/156
@eolivelli Sure, I'll fix that. Thanks for checking it out !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper pull request #156: BOOKKEEPER-1055: Optimize handling of masterKe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/bookkeeper/pull/156
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---