You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2025/01/20 19:10:40 UTC
Re: [PR] fix: Improve testing for array_remove and fallback to Spark for unsupported types [datafusion-comet]
codecov-commenter commented on PR #1308:
URL: https://github.com/apache/datafusion-comet/pull/1308#issuecomment-2603096629
## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1308?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `85.86957%` with `13 lines` in your changes missing coverage. Please review.
> Project coverage is 34.83%. Comparing base [(`be48839`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/be488390dcd89b2a5bff6f24b9ae7724383cffde?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`f8f244c`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/f8f244c3ba350aa94360ae12c1e5c3804d307540?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 17 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/datafusion-comet/pull/1308?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...la/org/apache/comet/testing/ParquetGenerator.scala](https://app.codecov.io/gh/apache/datafusion-comet/pull/1308?src=pr&el=tree&filepath=spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fcomet%2Ftesting%2FParquetGenerator.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9jb21ldC90ZXN0aW5nL1BhcnF1ZXRHZW5lcmF0b3Iuc2NhbGE=) | 89.39% | [1 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/datafusion-comet/pull/1308?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...src/main/scala/org/apache/comet/serde/arrays.scala](https://app.codecov.io/gh/apache/datafusion-comet/pull/1308?src=pr&el=tree&filepath=spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fcomet%2Fserde%2Farrays.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9jb21ldC9zZXJkZS9hcnJheXMuc2NhbGE=) | 66.66% | [1 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/datafusion-comet/pull/1308?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #1308 +/- ##
============================================
+ Coverage 34.69% 34.83% +0.13%
+ Complexity 991 985 -6
============================================
Files 116 119 +3
Lines 44891 45139 +248
Branches 9864 9954 +90
============================================
+ Hits 15574 15722 +148
- Misses 26168 26226 +58
- Partials 3149 3191 +42
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/1308?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org