[jira] [Created] (CB-9205) Whitelist "launch-external" setting does nothing

["Steve Hull (JIRA)" <ji...@apache.org>]

Steve Hull created CB-9205:
------------------------------

             Summary: Whitelist "launch-external" setting does nothing
                 Key: CB-9205
                 URL: https://issues.apache.org/jira/browse/CB-9205
             Project: Apache Cordova
          Issue Type: Bug
    Affects Versions: 3.8.0
         Environment: OSX 10.10
Cordova 3.8.0
iOS 8.3
            Reporter: Steve Hull


according to [cordova docs|http://cordova.apache.org/docs/en/4.0.0/guide_appdev_whitelist_index.md.html#external-application-whitelist], you should be able to specify in the config file which urls will open in an external browser by setting:

{{<access origin="http://example.com/*" launch-external="yes" />}}

However this does nothing.

I've looked into the definition of {{shouldStartLoadWithRequest}}, and it does indeed have a line near the bottom that would load the url in the external system browser ({{[[UIApplication sharedApplication] openURL:url]}}), however it appears that it would be impossible for this line to be executed as long as the protocol is {{http}} or {{https}}.

I'm not sure what the "correct" way is to address this, however it seems that old versions of the docs should be updated to reflect that {{launch-external}} does not do anything and maybe we could start paying attention to that config attribute going forward.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org