You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/01 04:14:05 UTC

[GitHub] [incubator-tvm] tqchen opened a new pull request #4606: [REFACTOR] Unify approach to Visitor/Mutator under Functor

tqchen opened a new pull request #4606: [REFACTOR] Unify approach to Visitor/Mutator under Functor
URL: https://github.com/apache/incubator-tvm/pull/4606
 
 
   IRMutator and IRVisitor were the main data structures for doing low level IR visiting.
   As the project evolves, we start to introduce more powerful variants such as StmtFunctor and ExprFunctor.
   This PR brings new classes that allows us to migrate the visitor mutator to be sub-class of these functors.
   
   List of changes:
   
   - Create separate class for ExprMutator and StmtMutator, following convention used in relay.
   - Introduce copy-on-write to StmtMutator that can later benefit the statement mutations
     if we use move semantics and keep a single copy of stmt.
   - Move two generic visit mutate util to use the new classes.
   
   We will send followup PRs to migrate the existing passes that use the legacy visitors
   to the new one.
   
   Thanks for contributing to TVM!   Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4606: [REFACTOR] Unify approach to Visitor/Mutator under Functor

Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #4606: [REFACTOR] Unify approach to Visitor/Mutator under Functor
URL: https://github.com/apache/incubator-tvm/pull/4606#issuecomment-570019324
 
 
   cc @icemelon9 @yzhliu @Hzfengsy @ZihengJiang @wweic 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen merged pull request #4606: [REFACTOR] Unify approach to Visitor/Mutator under Functor

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #4606: [REFACTOR] Unify approach to Visitor/Mutator under Functor
URL: https://github.com/apache/incubator-tvm/pull/4606
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen commented on issue #4606: [REFACTOR] Unify approach to Visitor/Mutator under Functor

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4606: [REFACTOR] Unify approach to Visitor/Mutator under Functor
URL: https://github.com/apache/incubator-tvm/pull/4606#issuecomment-570019324
 
 
   cc @icemelon9 @yzhliu @Hzfengsy @ZihengJiang 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services