You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by jo...@apache.org on 2021/04/26 06:48:23 UTC
[commons-fileupload] branch master updated: FILEUPLOAD-315 - java8
improvement:
This is an automated email from the ASF dual-hosted git repository.
jochen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git
The following commit(s) were added to refs/heads/master by this push:
new f2fa3c4 FILEUPLOAD-315 - java8 improvement:
new 6642724 Merge pull request #65 from arturobernalg/feature/FILEUPLOAD-315
f2fa3c4 is described below
commit f2fa3c4b49493048dbc7b73fe568e6884550fa60
Author: Arturo Bernal <ar...@gmail.com>
AuthorDate: Fri Apr 23 07:10:38 2021 +0200
FILEUPLOAD-315 - java8 improvement:
* Use computeIfAbsent
---
src/main/java/org/apache/commons/fileupload2/FileUploadBase.java | 7 +------
.../org/apache/commons/fileupload2/util/FileItemHeadersImpl.java | 6 +-----
2 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/src/main/java/org/apache/commons/fileupload2/FileUploadBase.java b/src/main/java/org/apache/commons/fileupload2/FileUploadBase.java
index f0d6582..3bb610b 100644
--- a/src/main/java/org/apache/commons/fileupload2/FileUploadBase.java
+++ b/src/main/java/org/apache/commons/fileupload2/FileUploadBase.java
@@ -386,12 +386,7 @@ public abstract class FileUploadBase {
for (final FileItem fileItem : items) {
final String fieldName = fileItem.getFieldName();
- List<FileItem> mappedItems = itemsMap.get(fieldName);
-
- if (mappedItems == null) {
- mappedItems = new ArrayList<>();
- itemsMap.put(fieldName, mappedItems);
- }
+ List<FileItem> mappedItems = itemsMap.computeIfAbsent(fieldName, k -> new ArrayList<>());
mappedItems.add(fileItem);
}
diff --git a/src/main/java/org/apache/commons/fileupload2/util/FileItemHeadersImpl.java b/src/main/java/org/apache/commons/fileupload2/util/FileItemHeadersImpl.java
index 06fdf60..2c237a7 100644
--- a/src/main/java/org/apache/commons/fileupload2/util/FileItemHeadersImpl.java
+++ b/src/main/java/org/apache/commons/fileupload2/util/FileItemHeadersImpl.java
@@ -87,11 +87,7 @@ public class FileItemHeadersImpl implements FileItemHeaders, Serializable {
*/
public synchronized void addHeader(final String name, final String value) {
final String nameLower = name.toLowerCase(Locale.ENGLISH);
- List<String> headerValueList = headerNameToValueListMap.get(nameLower);
- if (null == headerValueList) {
- headerValueList = new ArrayList<>();
- headerNameToValueListMap.put(nameLower, headerValueList);
- }
+ List<String> headerValueList = headerNameToValueListMap.computeIfAbsent(nameLower, k -> new ArrayList<>());
headerValueList.add(value);
}