You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org> on 2020/01/22 21:42:19 UTC
[Impala-ASF-CR] IMPALA-4080 [part 1]: Move codegen code from aggregation exec nodes to their plan nodes
Hello Daniel Becker, Tim Armstrong, Csaba Ringhofer,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15053
to look at the new patch set (#4).
Change subject: IMPALA-4080 [part 1]: Move codegen code from aggregation exec nodes to their plan nodes
......................................................................
IMPALA-4080 [part 1]: Move codegen code from aggregation exec nodes to
their plan nodes
Refactored code to move codegen code from aggregation exec nodes to
their plan nodes. Added some TODOs that will be fixed in the next few
patch.
Testing:
- Ran queries and confirmed manually that the codegen code works perfectly.
- ran all tests for agg nodes and partition joins
Change-Id: I58f52a262ac7d0af259d5bcda72ada93a851d3b2
---
M be/src/exec/aggregation-node-base.cc
M be/src/exec/aggregator.cc
M be/src/exec/aggregator.h
M be/src/exec/grouping-aggregator.cc
M be/src/exec/grouping-aggregator.h
M be/src/exec/hash-table.cc
M be/src/exec/hash-table.h
M be/src/exec/non-grouping-aggregator.cc
M be/src/exec/non-grouping-aggregator.h
M be/src/exec/partitioned-hash-join-builder.cc
M be/src/exec/partitioned-hash-join-builder.h
M be/src/exec/partitioned-hash-join-node.cc
M be/src/exprs/expr-test.cc
M be/src/exprs/scalar-expr.cc
M be/src/exprs/scalar-expr.h
15 files changed, 451 insertions(+), 213 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/15053/4
--
To view, visit http://gerrit.cloudera.org:8080/15053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58f52a262ac7d0af259d5bcda72ada93a851d3b2
Gerrit-Change-Number: 15053
Gerrit-PatchSet: 4
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>