You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "shenshengli (Jira)" <ji...@apache.org> on 2021/01/06 08:06:00 UTC

[jira] [Issue Comment Deleted] (HBASE-25449) 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml

     [ https://issues.apache.org/jira/browse/HBASE-25449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

shenshengli updated HBASE-25449:
--------------------------------
    Comment: was deleted

(was: I see. You want the hdfs-site.xml configuration to shine through if it is NOT set in hbase? Is that so? If that is the case, the PR makes sense to me. Is it possible to add a test? Thank you.

I added a unit test to demonstrate my purpose : Make this configuration empty in hbase-default.xml , get values in hdfs-default.xml or hdfs-site.xml.)

> 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml
> ---------------------------------------------------------------------
>
>                 Key: HBASE-25449
>                 URL: https://issues.apache.org/jira/browse/HBASE-25449
>             Project: HBase
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 2.0.1
>            Reporter: shenshengli
>            Assignee: shenshengli
>            Priority: Major
>
> I think this parameter is not suitable for in hbase-default.xml, because in this case, HDFS explicitly set to "dfs.client.read.shortcircuit=true", hbase rely on HDFS configuration, the parameters in hbase service still is false.Must be explicitly in hbase-site.xml is set to "dfs.client.read.shortcircuit=true" to take effect.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)