You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Rainer Jung <ra...@kippdata.de> on 2007/04/18 09:24:19 UTC

Re: svn commit: r529444 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina/manager: HTMLManagerServlet.java JspHelper.java util/ util/BaseSessionComparator.java util/ReverseComparator.java util/SessionUtils.java

Hi,

I have a patch for the 5.0/5.5 Manager webapp, which I could port to 6.0 
if there is some interest in it. Since Rémy was recently giving 
additional value to the manager webapp in 6.0, this patch could fit very 
well.

I described it's functionality and use some time ago. The mail is 
archived at

http://marc.info/?l=tomcat-dev&m=114125602727531&w=2

Feedback welcome.

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: svn commit: r529444 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina/manager: HTMLManagerServlet.java JspHelper.java util/ util/BaseSessionComparator.java util/ReverseComparator.java util/SessionUtils.java

Posted by Rainer Jung <ra...@kippdata.de>.
I tested and updated my patch. It now uses the URL /expire and leaves 
/sessions to Rémys session administration extensions.

The patch builds against 6.0.x head.

The functionality works in HTML Manager and also in the non HTML manager 
servlet. In HTML-Manager you can test it by Clicking on the "Expire 
Sessions" button in the apps list. The default timeout value is the 
webapp session timeout. The button expires sessions which are longer 
idle than the value in the form and also it produces an answer message 
in the message part of the list with an idle time histogram of all sessions.

http://people.apache.org/~rjung/patches/tomcatManagerSessionExpireCodePatch.txt 


Still an old docs patch against 5.0.28 (just to get an idea) is:

http://people.apache.org/~rjung/patches/tomcatManagerSessionExpireDocsPatch.txt 


Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: svn commit: r529444 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina/manager: HTMLManagerServlet.java JspHelper.java util/ util/BaseSessionComparator.java util/ReverseComparator.java util/SessionUtils.java

Posted by Rainer Jung <ra...@kippdata.de>.
I'm a little narrow on time at the moment, but I did a quick port of my 
old 5.0 patch to 6.0 head.

I didn't yet test the 6.0 port (nor build it), but you might get an idea 
about the amount of things the patch touches. My original 5.0 patch was 
used quite some time.

I won't insist on URL/action the feature can be called by. Originally it 
was an extension to /sessions for both the Manager and the HTML Manager. 
Since now you added nice detailed sessions functions to /sessions, it 
would either be another URL or a sub action. To make the patch simple, I 
  simply again occupied /sessions and put the detailed session 
management under another URL (mostly because it wasn't there in the 
Manager).

If there is some basic interest in it, I would test and polish it.

The patch is at:

http://people.apache.org/~rjung/patches/tomcatManagerSessionExpireCodePatch.txt

An old docs patch against 5.0.28 (just to get an idea) is:

http://people.apache.org/~rjung/patches/tomcatManagerSessionExpireDocsPatch.txt

I think this feature is not obsoleted by the new detailed session 
administration, because it allows a statistical view and a simple mass 
expiration by idle time. For me it looks like a good fit to the new 
management of individual sessions.

Regards,

Rainer

Remy Maucherat wrote:
> Rainer Jung wrote:
>> Hi,
>>
>> I have a patch for the 5.0/5.5 Manager webapp, which I could port to 
>> 6.0 if there is some interest in it. Since Rémy was recently giving 
>> additional value to the manager webapp in 6.0, this patch could fit 
>> very well.
>>
>> I described it's functionality and use some time ago. The mail is 
>> archived at
>>
>> http://marc.info/?l=tomcat-dev&m=114125602727531&w=2
> 
> What would the patch be ?
> 
> Rémy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: svn commit: r529444 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina/manager: HTMLManagerServlet.java JspHelper.java util/ util/BaseSessionComparator.java util/ReverseComparator.java util/SessionUtils.java

Posted by Remy Maucherat <re...@apache.org>.
Rainer Jung wrote:
> Hi,
> 
> I have a patch for the 5.0/5.5 Manager webapp, which I could port to 6.0 
> if there is some interest in it. Since Rémy was recently giving 
> additional value to the manager webapp in 6.0, this patch could fit very 
> well.
> 
> I described it's functionality and use some time ago. The mail is 
> archived at
> 
> http://marc.info/?l=tomcat-dev&m=114125602727531&w=2

What would the patch be ?

Rémy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org