You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "justinpakzad (via GitHub)" <gi...@apache.org> on 2026/01/01 21:50:32 UTC
[PR] Updated conf imports for standard/es/os/ms providers [airflow]
justinpakzad opened a new pull request, #60030:
URL: https://github.com/apache/airflow/pull/60030
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Updated standard, elasticsearch, opensearch, and microsoft providers to use airflow.sdk.configuration.conf instead of airflow.configuration.conf. One thing worth mentioning is that for elastic search I needed to add the `elasticsearch_configs` to the `unit_tests.cfg` file and `fallback="_all"` for the index_patterns. Without those some of the tests were failing and unable to read the necessary config.
related: #6000
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updated conf imports for standard/es/os/ms providers [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #60030:
URL: https://github.com/apache/airflow/pull/60030#discussion_r2659129765
##########
airflow-core/src/airflow/config_templates/unit_tests.cfg:
##########
@@ -126,6 +126,10 @@ ssl_assert_hostname = False
ssl_show_warn = False
ca_certs =
+[elasticsearch_configs]
Review Comment:
Makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updated conf imports for standard/es/os/ms providers [airflow]
Posted by "justinpakzad (via GitHub)" <gi...@apache.org>.
justinpakzad commented on PR #60030:
URL: https://github.com/apache/airflow/pull/60030#issuecomment-3704202508
The test failure seems to be unrelated to any of the changes I made: "Login output not found before command output for 'airflowctl dags update --dag-id=example_bash_operator --no-is-paused'". I rebased before pushing as well to make sure my branch is up to date.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updated conf imports for standard/es/os/ms providers [airflow]
Posted by "sunank200 (via GitHub)" <gi...@apache.org>.
sunank200 commented on code in PR #60030:
URL: https://github.com/apache/airflow/pull/60030#discussion_r2657558065
##########
airflow-core/src/airflow/config_templates/unit_tests.cfg:
##########
@@ -126,6 +126,10 @@ ssl_assert_hostname = False
ssl_show_warn = False
ca_certs =
+[elasticsearch_configs]
Review Comment:
Why do we need these configs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updated conf imports for standard/es/os/ms providers [airflow]
Posted by "justinpakzad (via GitHub)" <gi...@apache.org>.
justinpakzad commented on code in PR #60030:
URL: https://github.com/apache/airflow/pull/60030#discussion_r2657747742
##########
airflow-core/src/airflow/config_templates/unit_tests.cfg:
##########
@@ -126,6 +126,10 @@ ssl_assert_hostname = False
ssl_show_warn = False
ca_certs =
+[elasticsearch_configs]
Review Comment:
Because without them some of the tests would fail. The original configuration.py in airflow-core has more fallbacks, specifically it would fallback to `provider_config_fallback_defaults.cfg`, which is why the tests were working fine previously. In the new SDK implementation we don't have that fallback, so I needed to add it to the unit test config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updated conf imports for standard/es/os/ms providers [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #60030:
URL: https://github.com/apache/airflow/pull/60030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org