You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/12/25 07:33:45 UTC
[GitHub] [servicecomb-java-chassis] develpoerX opened a new pull request #2168: SCB-2172 - Multi-frame docking ServiceComb-Kie unified Kie Client common code
develpoerX opened a new pull request #2168:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2168
…mon code
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-io edited a comment on pull request #2168: SCB-2172 - Multi-frame docking ServiceComb-Kie unified Kie Client common code
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #2168:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2168#issuecomment-751202397
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168?src=pr&el=h1) Report
> Merging [#2168](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168?src=pr&el=desc) (1b21386) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/43975bd8ca95f76b698e4ba585778c71ff84bb12?el=desc) (43975bd) will **increase** coverage by `0.13%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2168 +/- ##
============================================
+ Coverage 80.67% 80.80% +0.13%
Complexity 1339 1339
============================================
Files 1462 1451 -11
Lines 40186 39880 -306
Branches 3412 3396 -16
============================================
- Hits 32419 32226 -193
+ Misses 6300 6203 -97
+ Partials 1467 1451 -16
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168/diff?src=pr&el=tree#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `96.49% <0.00%> (-3.51%)` | `0.00% <0.00%> (ø%)` | |
| [...pache/servicecomb/config/kie/client/KieClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168/diff?src=pr&el=tree#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWtpZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2tpZS9jbGllbnQvS2llQ2xpZW50LmphdmE=) | | | |
| [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168/diff?src=pr&el=tree#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `70.48% <0.00%> (+1.16%)` | `0.00% <0.00%> (ø%)` | |
| [...mb/serviceregistry/client/http/RestClientUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168/diff?src=pr&el=tree#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1Jlc3RDbGllbnRVdGlsLmphdmE=) | `77.57% <0.00%> (+1.86%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168?src=pr&el=footer). Last update [43975bd...0935b85](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #2168: SCB-2172 - Multi-frame docking ServiceComb-Kie unified Kie Client common code
Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #2168:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2168
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-io edited a comment on pull request #2168: SCB-2172 - Multi-frame docking ServiceComb-Kie unified Kie Client common code
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #2168:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2168#issuecomment-751202397
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168?src=pr&el=h1) Report
> Merging [#2168](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168?src=pr&el=desc) (0935b85) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/43975bd8ca95f76b698e4ba585778c71ff84bb12?el=desc) (43975bd) will **increase** coverage by `0.11%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2168 +/- ##
============================================
+ Coverage 80.67% 80.78% +0.11%
Complexity 1339 1339
============================================
Files 1462 1451 -11
Lines 40186 39880 -306
Branches 3412 3396 -16
============================================
- Hits 32419 32218 -201
+ Misses 6300 6210 -90
+ Partials 1467 1452 -15
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168/diff?src=pr&el=tree#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `96.49% <0.00%> (-3.51%)` | `0.00% <0.00%> (ø%)` | |
| [...pache/servicecomb/config/kie/client/KieClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168/diff?src=pr&el=tree#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWtpZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2tpZS9jbGllbnQvS2llQ2xpZW50LmphdmE=) | | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168?src=pr&el=footer). Last update [43975bd...0935b85](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-io commented on pull request #2168: SCB-2172 - Multi-frame docking ServiceComb-Kie unified Kie Client common code
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2168:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2168#issuecomment-751202397
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168?src=pr&el=h1) Report
> Merging [#2168](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168?src=pr&el=desc) (35f5456) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/43975bd8ca95f76b698e4ba585778c71ff84bb12?el=desc) (43975bd) will **decrease** coverage by `0.02%`.
> The diff coverage is `18.91%`.
[](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2168 +/- ##
============================================
- Coverage 80.67% 80.64% -0.03%
Complexity 1339 1339
============================================
Files 1462 1454 -8
Lines 40186 39981 -205
Branches 3412 3403 -9
============================================
- Hits 32419 32242 -177
+ Misses 6300 6284 -16
+ Partials 1467 1455 -12
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ecomb/http/client/common/HttpTransportFactory.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168/diff?src=pr&el=tree#diff-Y2xpZW50cy9odHRwLWNsaWVudC1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2h0dHAvY2xpZW50L2NvbW1vbi9IdHRwVHJhbnNwb3J0RmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...omb/service/center/client/ServiceCenterClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168/diff?src=pr&el=tree#diff-Y2xpZW50cy9zZXJ2aWNlLWNlbnRlci1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3NlcnZpY2UvY2VudGVyL2NsaWVudC9TZXJ2aWNlQ2VudGVyQ2xpZW50LmphdmE=) | `27.41% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...o/multiServiceCenterClient/RegistryClientTest.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168/diff?src=pr&el=tree#diff-ZGVtby9kZW1vLW11bHRpLXNlcnZpY2UtY2VudGVyL2RlbW8tbXVsdGktc2VydmljZS1jZW50ZXItY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9kZW1vL211bHRpU2VydmljZUNlbnRlckNsaWVudC9SZWdpc3RyeUNsaWVudFRlc3QuamF2YQ==) | `88.50% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| [...omb/serviceregistry/auth/RBACBootStrapService.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168/diff?src=pr&el=tree#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2F1dGgvUkJBQ0Jvb3RTdHJhcFNlcnZpY2UuamF2YQ==) | `5.06% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...b/http/client/common/auth/AKSKHeaderExtension.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168/diff?src=pr&el=tree#diff-Y2xpZW50cy9odHRwLWNsaWVudC1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2h0dHAvY2xpZW50L2NvbW1vbi9hdXRoL0FLU0tIZWFkZXJFeHRlbnNpb24uamF2YQ==) | `12.50% <12.50%> (ø)` | `0.00 <0.00> (?)` | |
| [...ommon/auth/FileSystemMountAKSKHeaderExtension.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168/diff?src=pr&el=tree#diff-Y2xpZW50cy9odHRwLWNsaWVudC1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2h0dHAvY2xpZW50L2NvbW1vbi9hdXRoL0ZpbGVTeXN0ZW1Nb3VudEFLU0tIZWFkZXJFeHRlbnNpb24uamF2YQ==) | `14.70% <14.70%> (ø)` | `0.00 <0.00> (?)` | |
| [...cecomb/http/client/common/auth/AKSKHeaderUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168/diff?src=pr&el=tree#diff-Y2xpZW50cy9odHRwLWNsaWVudC1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2h0dHAvY2xpZW50L2NvbW1vbi9hdXRoL0FLU0tIZWFkZXJVdGlsLmphdmE=) | `16.66% <16.66%> (ø)` | `0.00 <0.00> (?)` | |
| [...vicecomb/http/client/common/HttpConfiguration.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168/diff?src=pr&el=tree#diff-Y2xpZW50cy9odHRwLWNsaWVudC1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2h0dHAvY2xpZW50L2NvbW1vbi9IdHRwQ29uZmlndXJhdGlvbi5qYXZh) | `13.33% <20.00%> (+13.33%)` | `0.00 <0.00> (ø)` | |
| [...tp/client/common/auth/AKSKHeaderExtensionUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168/diff?src=pr&el=tree#diff-Y2xpZW50cy9odHRwLWNsaWVudC1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2h0dHAvY2xpZW50L2NvbW1vbi9hdXRoL0FLU0tIZWFkZXJFeHRlbnNpb25VdGlsLmphdmE=) | `40.00% <40.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...vicecomb/http/client/common/HttpTransportImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168/diff?src=pr&el=tree#diff-Y2xpZW50cy9odHRwLWNsaWVudC1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2h0dHAvY2xpZW50L2NvbW1vbi9IdHRwVHJhbnNwb3J0SW1wbC5qYXZh) | `59.25% <100.00%> (-1.46%)` | `0.00 <0.00> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168?src=pr&el=footer). Last update [43975bd...35f5456](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2168?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org