[jira] [Commented] (BAHIR-155) Add expire to redis sink

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BAHIR-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948026#comment-16948026 ] 

ASF GitHub Bot commented on BAHIR-155:
--------------------------------------

tutss commented on pull request #66: [BAHIR-155] TTL to HSET and SETEX command
URL: https://github.com/apache/bahir-flink/pull/66
 
 
   This PR introduces some new functionality, following [BAHIR-155 Jira discussion](https://issues.apache.org/jira/projects/BAHIR/issues/BAHIR-155?filter=allopenissues):
   
   - Possibility to include TTL to a HASH in HSET operation.
   - SETEX command.
   
   Tests for each respective change were included.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add expire to redis sink 
> -------------------------
>
>                 Key: BAHIR-155
>                 URL: https://issues.apache.org/jira/browse/BAHIR-155
>             Project: Bahir
>          Issue Type: Wish
>          Components: Flink Streaming Connectors
>    Affects Versions: Flink-1.0
>            Reporter: miki haiat
>            Priority: Major
>              Labels: features
>             Fix For: Flink-1.0
>
>
>  I have a scenario that  im collection some MD and aggregate the result by time .
> for example Each HSET of each window can create different values 
> by adding expiry i can guarantee  that the key is holding only the current window values 
> im thinking  to change the  the interface signuter 
>   
> {code:java}
>  void hset(String key, String hashField, String value);
>  void set(String key, String value);
> //to this 
>  void hset(String key, String hashField, String value,int expire);
>  void set(String key, String value,int expire);
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)