You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/03 17:25:39 UTC

[GitHub] [arrow] amol- commented on a change in pull request #11076: ARROW-6626: [Python] Support converting nested sets when converting to arrow

amol- commented on a change in pull request #11076:
URL: https://github.com/apache/arrow/pull/11076#discussion_r702057763



##########
File path: python/pyarrow/tests/test_dataset.py
##########
@@ -575,7 +575,7 @@ def test_expression_construction():
         field.isin(1)
 
     with pytest.raises(pa.ArrowInvalid):
-        field != {1}
+        field != object()

Review comment:
       Previously it was using `set` because we didn't support converting sets to scalar values. For `field != [1]` the code didn't raise because we supported converting lists to scalars.
   
   Now we also support converting `sets` and thus we need to use a different entity to actually trigger an invalid filter. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org