You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/09 11:28:53 UTC
[GitHub] [cloudstack-documentation] Spaceman1984 opened a new pull request #187: Disk provisioning types vmware
Spaceman1984 opened a new pull request #187:
URL: https://github.com/apache/cloudstack-documentation/pull/187
Changes related to VMware disk provisioning types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] sureshanaparti commented on a change in pull request #187: Disk provisioning types vmware
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #187:
URL: https://github.com/apache/cloudstack-documentation/pull/187#discussion_r573548544
##########
File path: source/adminguide/service_offerings.rst
##########
@@ -187,8 +187,17 @@ To create a new compute offering:
system VM is running. Shared allocates from storage accessible via
NFS.
- - **Provisioning type**: The type of disk that should be allocated.
- Local
+ - **Provisioning type**: The type of disk that should be allocated.
+ Valid values are thin, sparse, fat. When using the VMWare hypervisor,
+ these values map as follows:
+
+ - **Thin** - **Thin**.
+ - **Sparse** - **Thick provisioned lazily zeroed**.
+ - **Fat** - **Thick provisioned eagerly zeroed**.
+
+ The disk provisioning type strictness on VMWare iscontrolled with the zone level setting - **disk.provisioning.type.strictness**
Review comment:
```suggestion
The disk provisioning type strictness on VMWare is controlled with the zone level setting - **disk.provisioning.type.strictness**
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] Spaceman1984 commented on pull request #187: Disk provisioning types vmware
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #187:
URL: https://github.com/apache/cloudstack-documentation/pull/187#issuecomment-852919401
Created a new pull request #217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] rhtyd merged pull request #187: Disk provisioning types vmware
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #187:
URL: https://github.com/apache/cloudstack-documentation/pull/187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] sureshanaparti commented on a change in pull request #187: Disk provisioning types vmware
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #187:
URL: https://github.com/apache/cloudstack-documentation/pull/187#discussion_r580144288
##########
File path: source/quickinstallationguide/qig.rst
##########
@@ -433,6 +433,13 @@ Install Python MySQL connector from the MySQL community repository (which we've
Please note that the previously required ``mysql-connector-java`` library is now bundled with CloudStack
Management server and is no more required to be installed separately.
Review comment:
can you rebase and resolve properly. this changes shouldn't come up as changes in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] sureshanaparti commented on a change in pull request #187: Disk provisioning types vmware
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #187:
URL: https://github.com/apache/cloudstack-documentation/pull/187#discussion_r573554903
##########
File path: source/quickinstallationguide/qig.rst
##########
@@ -433,6 +433,13 @@ Install Python MySQL connector from the MySQL community repository (which we've
Please note that the previously required ``mysql-connector-java`` library is now bundled with CloudStack
Management server and is no more required to be installed separately.
Review comment:
Seems the changes here, are not related to disk provisioning types. Please check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] sureshanaparti commented on a change in pull request #187: Disk provisioning types vmware
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #187:
URL: https://github.com/apache/cloudstack-documentation/pull/187#discussion_r573547925
##########
File path: source/adminguide/service_offerings.rst
##########
@@ -187,8 +187,17 @@ To create a new compute offering:
system VM is running. Shared allocates from storage accessible via
NFS.
- - **Provisioning type**: The type of disk that should be allocated.
- Local
+ - **Provisioning type**: The type of disk that should be allocated.
+ Valid values are thin, sparse, fat. When using the VMWare hypervisor,
+ these values map as follows:
Review comment:
```suggestion
these values are mapped to the following vSphere disk provisioning types:
- **thin** - **Thin Provision**
- **sparse** - **Thick Provision Lazy Zeroed**
- **fat** - **Thick Provision Eager Zeroed**
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] rhtyd commented on pull request #187: Disk provisioning types vmware
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #187:
URL: https://github.com/apache/cloudstack-documentation/pull/187#issuecomment-852969515
Thanks @DaanHoogland
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] Spaceman1984 commented on a change in pull request #187: Disk provisioning types vmware
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #187:
URL: https://github.com/apache/cloudstack-documentation/pull/187#discussion_r573565549
##########
File path: source/adminguide/service_offerings.rst
##########
@@ -383,6 +392,18 @@ To create a new disk offering:
- **Disk Size**: Appears only if Custom Disk Size is not selected.
Define the volume size in GB (2^30 1GB = 1,073,741,824 Bytes).
+ - **Provisioning type**: The type of disk that should be allocated.
+ Valid values are thin, sparse, fat. When using the VMWare hypervisor,
+ these values map as follows:
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #187: Disk provisioning types vmware
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #187:
URL: https://github.com/apache/cloudstack-documentation/pull/187#issuecomment-852905805
@rhtyd I think the code PR is for 4.16. should this doc-change be marked for 4.15?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] Spaceman1984 commented on a change in pull request #187: Disk provisioning types vmware
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #187:
URL: https://github.com/apache/cloudstack-documentation/pull/187#discussion_r573556095
##########
File path: source/quickinstallationguide/qig.rst
##########
@@ -433,6 +433,13 @@ Install Python MySQL connector from the MySQL community repository (which we've
Please note that the previously required ``mysql-connector-java`` library is now bundled with CloudStack
Management server and is no more required to be installed separately.
Review comment:
This was a conflict that I had to resolve
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] sureshanaparti commented on a change in pull request #187: Disk provisioning types vmware
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #187:
URL: https://github.com/apache/cloudstack-documentation/pull/187#discussion_r573549060
##########
File path: source/adminguide/service_offerings.rst
##########
@@ -383,6 +392,18 @@ To create a new disk offering:
- **Disk Size**: Appears only if Custom Disk Size is not selected.
Define the volume size in GB (2^30 1GB = 1,073,741,824 Bytes).
+ - **Provisioning type**: The type of disk that should be allocated.
+ Valid values are thin, sparse, fat. When using the VMWare hypervisor,
+ these values map as follows:
Review comment:
same suggestion as above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #187: Disk provisioning types vmware
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #187:
URL: https://github.com/apache/cloudstack-documentation/pull/187#issuecomment-852950008
revert as PR #218 not sure if we need reviews there @rhtyd so merge at will.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] rhtyd commented on pull request #187: Disk provisioning types vmware
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #187:
URL: https://github.com/apache/cloudstack-documentation/pull/187#issuecomment-852915554
:facepalm: nope you're right @DaanHoogland @Spaceman1984 can you open a PR for master branch, I'll revert the change on 4.15 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] Spaceman1984 commented on a change in pull request #187: Disk provisioning types vmware
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #187:
URL: https://github.com/apache/cloudstack-documentation/pull/187#discussion_r573565668
##########
File path: source/adminguide/service_offerings.rst
##########
@@ -187,8 +187,17 @@ To create a new compute offering:
system VM is running. Shared allocates from storage accessible via
NFS.
- - **Provisioning type**: The type of disk that should be allocated.
- Local
+ - **Provisioning type**: The type of disk that should be allocated.
+ Valid values are thin, sparse, fat. When using the VMWare hypervisor,
+ these values map as follows:
+
+ - **Thin** - **Thin**.
+ - **Sparse** - **Thick provisioned lazily zeroed**.
+ - **Fat** - **Thick provisioned eagerly zeroed**.
+
+ The disk provisioning type strictness on VMWare iscontrolled with the zone level setting - **disk.provisioning.type.strictness**
+
Review comment:
Done
##########
File path: source/adminguide/service_offerings.rst
##########
@@ -383,6 +392,18 @@ To create a new disk offering:
- **Disk Size**: Appears only if Custom Disk Size is not selected.
Define the volume size in GB (2^30 1GB = 1,073,741,824 Bytes).
+ - **Provisioning type**: The type of disk that should be allocated.
+ Valid values are thin, sparse, fat. When using the VMWare hypervisor,
+ these values map as follows:
+
+ - **Thin** - **Thin**.
+ - **Sparse** - **Thick provisioned lazily zeroed**.
+ - **Fat** - **Thick provisioned eagerly zeroed**.
+
+ The disk provisioning type strictness on VMWare iscontrolled with the zone level setting - **disk.provisioning.type.strictness**
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] sureshanaparti commented on a change in pull request #187: Disk provisioning types vmware
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #187:
URL: https://github.com/apache/cloudstack-documentation/pull/187#discussion_r573553677
##########
File path: source/adminguide/service_offerings.rst
##########
@@ -187,8 +187,17 @@ To create a new compute offering:
system VM is running. Shared allocates from storage accessible via
NFS.
- - **Provisioning type**: The type of disk that should be allocated.
- Local
+ - **Provisioning type**: The type of disk that should be allocated.
+ Valid values are thin, sparse, fat. When using the VMWare hypervisor,
+ these values map as follows:
+
+ - **Thin** - **Thin**.
+ - **Sparse** - **Thick provisioned lazily zeroed**.
+ - **Fat** - **Thick provisioned eagerly zeroed**.
+
+ The disk provisioning type strictness on VMWare iscontrolled with the zone level setting - **disk.provisioning.type.strictness**
+
Review comment:
white space not required, as this stmt is related to the setting.
##########
File path: source/adminguide/service_offerings.rst
##########
@@ -383,6 +392,18 @@ To create a new disk offering:
- **Disk Size**: Appears only if Custom Disk Size is not selected.
Define the volume size in GB (2^30 1GB = 1,073,741,824 Bytes).
+ - **Provisioning type**: The type of disk that should be allocated.
+ Valid values are thin, sparse, fat. When using the VMWare hypervisor,
+ these values map as follows:
+
+ - **Thin** - **Thin**.
+ - **Sparse** - **Thick provisioned lazily zeroed**.
+ - **Fat** - **Thick provisioned eagerly zeroed**.
+
+ The disk provisioning type strictness on VMWare iscontrolled with the zone level setting - **disk.provisioning.type.strictness**
Review comment:
check if this is redundant
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org