You are viewing a plain text version of this content. The canonical link for it is here.
Posted to apreq-cvs@httpd.apache.org by jo...@apache.org on 2004/07/01 14:34:53 UTC
cvs commit: httpd-apreq-2/glue/perl/xsbuilder/Apache/Upload Upload_pm
joes 2004/07/01 05:34:53
Modified: glue/perl/xsbuilder apreq_xs_postperl.h
glue/perl/xsbuilder/Apache/Cookie Cookie_pm
glue/perl/xsbuilder/Apache/Request Request_pm
glue/perl/xsbuilder/Apache/Upload Upload_pm
Log:
Replace C<require "APR/Error.pm"> from apreq_xs_croak with corresponding C<use APR::Error> in the *_pm files.
Revision Changes Path
1.30 +0 -1 httpd-apreq-2/glue/perl/xsbuilder/apreq_xs_postperl.h
Index: apreq_xs_postperl.h
===================================================================
RCS file: /home/cvs/httpd-apreq-2/glue/perl/xsbuilder/apreq_xs_postperl.h,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -r1.29 -r1.30
--- apreq_xs_postperl.h 1 Jul 2004 04:11:24 -0000 1.29
+++ apreq_xs_postperl.h 1 Jul 2004 12:34:53 -0000 1.30
@@ -379,7 +379,6 @@
{
HV *stash = gv_stashpvn(class, strlen(class), FALSE);
- Perl_require_pv(aTHX_ "APR/Error.pm");
if (SvTRUE(ERRSV)) {
Perl_croak(aTHX_ "%s", SvPV_nolen(ERRSV));
}
1.17 +1 -2 httpd-apreq-2/glue/perl/xsbuilder/Apache/Cookie/Cookie_pm
Index: Cookie_pm
===================================================================
RCS file: /home/cvs/httpd-apreq-2/glue/perl/xsbuilder/Apache/Cookie/Cookie_pm,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -r1.16 -r1.17
--- Cookie_pm 1 Jul 2004 04:11:24 -0000 1.16
+++ Cookie_pm 1 Jul 2004 12:34:53 -0000 1.17
@@ -1,6 +1,5 @@
-
-use APR;
use APR::Table;
+use APR::Error;
package Apache::Cookie::Jar;
push our(@ISA), __PACKAGE__ -> env;
1.16 +1 -0 httpd-apreq-2/glue/perl/xsbuilder/Apache/Request/Request_pm
Index: Request_pm
===================================================================
RCS file: /home/cvs/httpd-apreq-2/glue/perl/xsbuilder/Apache/Request/Request_pm,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- Request_pm 1 Jul 2004 04:11:24 -0000 1.15
+++ Request_pm 1 Jul 2004 12:34:53 -0000 1.16
@@ -1,4 +1,5 @@
use APR::Table;
+use APR::Error;
package Apache::Request::Table;
push our(@ISA), "APR::Table";
1.5 +4 -1 httpd-apreq-2/glue/perl/xsbuilder/Apache/Upload/Upload_pm
Index: Upload_pm
===================================================================
RCS file: /home/cvs/httpd-apreq-2/glue/perl/xsbuilder/Apache/Upload/Upload_pm,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- Upload_pm 28 Jun 2004 21:58:15 -0000 1.4
+++ Upload_pm 1 Jul 2004 12:34:53 -0000 1.5
@@ -1,9 +1,12 @@
-use APR;
use APR::Table;
use APR::Bucket;
use APR::Brigade;
use APR::PerlIO;
+use APR::Error;
use Apache::Request;
+
+package Apache::Upload::Error;
+push our(@ISA), "APR::Error";
package Apache::Upload::Table;
push our(@ISA), "APR::Table";
Re: cvs commit: httpd-apreq-2/glue/perl/xsbuilder/Apache/Upload Upload_pm
Posted by Joe Schaefer <jo...@sunstarsys.com>.
Stas Bekman <st...@stason.org> writes:
[...]
> > - Perl_require_pv(aTHX_ "APR/Error.pm");
> > if (SvTRUE(ERRSV)) {
> > Perl_croak(aTHX_ "%s", SvPV_nolen(ERRSV)); }
>
> in which case you no longer need to check whether it has failed.
Thanks Stas- clause removed.
--
Joe Schaefer
Re: cvs commit: httpd-apreq-2/glue/perl/xsbuilder/Apache/Upload Upload_pm
Posted by Stas Bekman <st...@stason.org>.
joes@apache.org wrote:
> joes 2004/07/01 05:34:53
>
> Modified: glue/perl/xsbuilder apreq_xs_postperl.h
> glue/perl/xsbuilder/Apache/Cookie Cookie_pm
> glue/perl/xsbuilder/Apache/Request Request_pm
> glue/perl/xsbuilder/Apache/Upload Upload_pm
> Log:
> Replace C<require "APR/Error.pm"> from apreq_xs_croak with corresponding C<use APR::Error> in the *_pm files.
>
> Revision Changes Path
> 1.30 +0 -1 httpd-apreq-2/glue/perl/xsbuilder/apreq_xs_postperl.h
>
> Index: apreq_xs_postperl.h
> ===================================================================
> RCS file: /home/cvs/httpd-apreq-2/glue/perl/xsbuilder/apreq_xs_postperl.h,v
> retrieving revision 1.29
> retrieving revision 1.30
> diff -u -r1.29 -r1.30
> --- apreq_xs_postperl.h 1 Jul 2004 04:11:24 -0000 1.29
> +++ apreq_xs_postperl.h 1 Jul 2004 12:34:53 -0000 1.30
> @@ -379,7 +379,6 @@
> {
> HV *stash = gv_stashpvn(class, strlen(class), FALSE);
>
> - Perl_require_pv(aTHX_ "APR/Error.pm");
> if (SvTRUE(ERRSV)) {
> Perl_croak(aTHX_ "%s", SvPV_nolen(ERRSV));
> }
in which case you no longer need to check whether it has failed.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com