You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/06/10 04:01:29 UTC
[GitHub] [incubator-dolphinscheduler] codecov-commenter edited a comment on pull request #2945: add http task timeout & test unit
codecov-commenter edited a comment on pull request #2945:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2945#issuecomment-641673005
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2945?src=pr&el=h1) Report
> Merging [#2945](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2945?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/2749c7e5369459c1a410508cc4769db37f4a0043&el=desc) will **increase** coverage by `0.43%`.
> The diff coverage is `100.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2945/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2945?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #2945 +/- ##
============================================
+ Coverage 37.20% 37.64% +0.43%
- Complexity 2559 2597 +38
============================================
Files 435 435
Lines 20020 20026 +6
Branches 2426 2426
============================================
+ Hits 7449 7538 +89
+ Misses 11904 11810 -94
- Partials 667 678 +11
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2945?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...phinscheduler/common/task/http/HttpParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2945/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svaHR0cC9IdHRwUGFyYW1ldGVycy5qYXZh) | `96.00% <100.00%> (+85.47%)` | `16.00 <4.00> (+15.00)` | |
| [...hinscheduler/server/worker/task/http/HttpTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2945/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL2h0dHAvSHR0cFRhc2suamF2YQ==) | `44.24% <100.00%> (+44.24%)` | `15.00 <1.00> (+15.00)` | |
| [...he/dolphinscheduler/api/service/LoggerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2945/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvTG9nZ2VyU2VydmljZS5qYXZh) | `82.60% <0.00%> (-8.70%)` | `9.00% <0.00%> (-1.00%)` | |
| [...he/dolphinscheduler/common/thread/ThreadUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2945/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9UaHJlYWRVdGlscy5qYXZh) | `68.25% <0.00%> (-6.35%)` | `13.00% <0.00%> (-1.00%)` | |
| [...cheduler/server/registry/ZookeeperNodeManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2945/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3JlZ2lzdHJ5L1pvb2tlZXBlck5vZGVNYW5hZ2VyLmphdmE=) | `74.72% <0.00%> (-3.30%)` | `6.00% <0.00%> (-1.00%)` | |
| [...pache/dolphinscheduler/common/utils/FileUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2945/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0ZpbGVVdGlscy5qYXZh) | `28.03% <0.00%> (-0.94%)` | `9.00% <0.00%> (ø%)` | |
| [...inscheduler/common/task/sqoop/SqoopParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2945/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3AvU3Fvb3BQYXJhbWV0ZXJzLmphdmE=) | `80.00% <0.00%> (ø)` | `15.00% <0.00%> (ø%)` | |
| [...er/server/worker/task/AbstractCommandExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2945/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0Q29tbWFuZEV4ZWN1dG9yLmphdmE=) | `0.56% <0.00%> (+0.56%)` | `1.00% <0.00%> (+1.00%)` | |
| [...ache/dolphinscheduler/server/utils/ParamUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2945/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1BhcmFtVXRpbHMuamF2YQ==) | `70.73% <0.00%> (+7.31%)` | `10.00% <0.00%> (+1.00%)` | |
| [...phinscheduler/server/worker/task/AbstractTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2945/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0VGFzay5qYXZh) | `8.00% <0.00%> (+8.00%)` | `1.00% <0.00%> (+1.00%)` | |
| ... and [4 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2945/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2945?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2945?src=pr&el=footer). Last update [2749c7e...a6926f6](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2945?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org