[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #232: Simplify how we show text differences when a TDML test fails

[GitBox <gi...@apache.org>]

mbeckerle commented on a change in pull request #232: Simplify how we show text differences when a TDML test fails
URL: https://github.com/apache/incubator-daffodil/pull/232#discussion_r292915620
 
 

 ##########
 File path: daffodil-lib/src/main/scala/org/apache/daffodil/xml/XMLUtils.scala
 ##########
 @@ -748,16 +748,13 @@ object XMLUtils {
 Comparison failed.
 Expected (attributes stripped)
           %s
-Actual (attributes stripped)
+Actual (attributes ignored for diff)
 
 Review comment:
   Do we have a test that verifies this ignore logic doesn't strip the xsi:nil attribute?  Just asking since Guichard had an issue related to that with EDIFACT recently, and I wanted to make sure the issue is not in the TDML comparison logic. I don't think it is, but wanted to check. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services