[GitHub] [systemds] BACtaki opened a new pull request, #1738: [MINOR] Adding a factory method for MatrixSketch

[GitBox <gi...@apache.org>]

BACtaki opened a new pull request, #1738:
URL: https://github.com/apache/systemds/pull/1738

   This patch introduces a factory method for sketches. This will centralize the creation of all sketches in one place and prevent duplication of operator switching and validation logic.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] Baunsgaard closed pull request #1738: [MINOR] Adding a factory method for MatrixSketch

[GitBox <gi...@apache.org>]

Baunsgaard closed pull request #1738: [MINOR] Adding a factory method for MatrixSketch
URL: https://github.com/apache/systemds/pull/1738


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] Baunsgaard commented on pull request #1738: [MINOR] Adding a factory method for MatrixSketch

[GitBox <gi...@apache.org>]

Baunsgaard commented on PR #1738:
URL: https://github.com/apache/systemds/pull/1738#issuecomment-1344169973

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org