You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/06/07 18:42:15 UTC

[GitHub] [kafka] jnewhouse opened a new pull request, #12263: KAFKA-13939: Only track dirty keys if logging is enabled.

jnewhouse opened a new pull request, #12263:
URL: https://github.com/apache/kafka/pull/12263

   InMemoryTimeOrderedKeyValueBuffer keeps a Set of keys
   that have been seen in order to log them for durability.
   This set is never used nor cleared if logging is not enabled.
   Having it be populated creates a memory leak.
   This change stops populating the set if logging is not enabled.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang merged pull request #12263: KAFKA-13939: Only track dirty keys if logging is enabled.

Posted by GitBox <gi...@apache.org>.
guozhangwang merged PR #12263:
URL: https://github.com/apache/kafka/pull/12263


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jnewhouse commented on pull request #12263: KAFKA-13939: Only track dirty keys if logging is enabled.

Posted by GitBox <gi...@apache.org>.
jnewhouse commented on PR #12263:
URL: https://github.com/apache/kafka/pull/12263#issuecomment-1152549176

   I don't think making a field nullable is worth the minor savings.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org