You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by li...@apache.org on 2024/07/29 09:12:58 UTC
(dubbo-go) 01/01: Revert "Temporarily remove the routers until fixed (#2718)"
This is an automated email from the ASF dual-hosted git repository.
liujun pushed a commit to branch revert-2718-fix-remove-router
in repository https://gitbox.apache.org/repos/asf/dubbo-go.git
commit a3fe848a2eda51c0c411ba7070dd9171966f391d
Author: Ken Liu <ke...@gmail.com>
AuthorDate: Mon Jul 29 17:12:47 2024 +0800
Revert "Temporarily remove the routers until fixed (#2718)"
This reverts commit ee3d011b2e28fafa732ce66c72ed95959fd0dd31.
---
cluster/router/condition/factory.go | 7 ++++---
cluster/router/tag/factory.go | 5 +++--
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/cluster/router/condition/factory.go b/cluster/router/condition/factory.go
index 840556dab..ecd7b5a35 100644
--- a/cluster/router/condition/factory.go
+++ b/cluster/router/condition/factory.go
@@ -19,12 +19,13 @@ package condition
import (
"dubbo.apache.org/dubbo-go/v3/cluster/router"
+ "dubbo.apache.org/dubbo-go/v3/common/constant"
+ "dubbo.apache.org/dubbo-go/v3/common/extension"
)
func init() {
- // TODO(finalt) Temporarily removed until fixed
- //extension.SetRouterFactory(constant.ConditionServiceRouterFactoryKey, NewServiceConditionRouterFactory)
- //extension.SetRouterFactory(constant.ConditionAppRouterFactoryKey, NewAppConditionRouterFactory)
+ extension.SetRouterFactory(constant.ConditionServiceRouterFactoryKey, NewServiceConditionRouterFactory)
+ extension.SetRouterFactory(constant.ConditionAppRouterFactoryKey, NewAppConditionRouterFactory)
}
// ServiceRouteFactory router factory
diff --git a/cluster/router/tag/factory.go b/cluster/router/tag/factory.go
index effc4b1c8..542ba4749 100644
--- a/cluster/router/tag/factory.go
+++ b/cluster/router/tag/factory.go
@@ -19,6 +19,8 @@ package tag
import (
"dubbo.apache.org/dubbo-go/v3/cluster/router"
+ "dubbo.apache.org/dubbo-go/v3/common/constant"
+ "dubbo.apache.org/dubbo-go/v3/common/extension"
)
func init() {
@@ -27,8 +29,7 @@ func init() {
and cause warning if config center is empty.
User can import this package and config config center to use tag router.
*/
- // TODO(finalt) Temporarily removed until fixed
- //extension.SetRouterFactory(constant.TagRouterFactoryKey, NewTagRouterFactory)
+ extension.SetRouterFactory(constant.TagRouterFactoryKey, NewTagRouterFactory)
}
// RouteFactory router factory