[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #3943: Segment creation with flexible file paths

[GitBox <gi...@apache.org>]

sunithabeeram commented on a change in pull request #3943: Segment creation with flexible file paths
URL: https://github.com/apache/incubator-pinot/pull/3943#discussion_r264003982
 
 

 ##########
 File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentCreationJob.java
 ##########
 @@ -104,6 +104,10 @@ public SegmentCreationJob(Properties properties) {
 
   @Override
   protected boolean isDataFile(String fileName) {
+    // Other files may have different extensions, eg: orc can have no extension
 
 Review comment:
   Other files =>Might be better to reword: "When user specified record-readers are used, files can have different/unknown extensions. e.g., orc can have no extension. Skip the check in this case."

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org