You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/11/08 02:56:00 UTC

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #885: Correct nsh library Kconfig

xiaoxiang781216 commented on a change in pull request #885:
URL: https://github.com/apache/incubator-nuttx-apps/pull/885#discussion_r744375037



##########
File path: nshlib/Kconfig
##########
@@ -728,16 +728,6 @@ config NSH_DISABLE_LOOPS
 
 endif # !NSH_DISABLESCRIPT
 
-config NSH_MMCSDMINOR

Review comment:
       > Isn't better to remove the other one? This one provides a better comment, IMO.
   
   No, that place contain other MMCSD related definition. So, I replace the description at that location with this one. Please review again.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org