You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "RocMarshal (via GitHub)" <gi...@apache.org> on 2024/12/01 00:27:26 UTC
Re: [PR] [FLINK-33265] Support source parallelism setting for Kafka connector [flink-connector-kafka]
RocMarshal commented on code in PR #134:
URL: https://github.com/apache/flink-connector-kafka/pull/134#discussion_r1863035596
##########
flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicTableFactoryTest.java:
##########
@@ -212,14 +212,56 @@ public void testTableSource() {
KAFKA_SOURCE_PROPERTIES,
StartupMode.SPECIFIC_OFFSETS,
specificOffsets,
- 0);
+ 0,
+ null);
assertThat(actualKafkaSource).isEqualTo(expectedKafkaSource);
ScanTableSource.ScanRuntimeProvider provider =
actualKafkaSource.getScanRuntimeProvider(ScanRuntimeProviderContext.INSTANCE);
assertKafkaSource(provider);
}
+ @Test
+ public void testTableSourceWithParallelism() {
+ final Map<String, String> modifiedOptions =
+ getModifiedOptions(
+ getBasicSourceOptions(), options -> options.put("scan.parallelism", "100"));
+ final DynamicTableSource actualSource = createTableSource(SCHEMA, modifiedOptions);
+ final KafkaDynamicSource actualKafkaSource = (KafkaDynamicSource) actualSource;
+
+ final Map<KafkaTopicPartition, Long> specificOffsets = new HashMap<>();
+ specificOffsets.put(new KafkaTopicPartition(TOPIC, PARTITION_0), OFFSET_0);
+ specificOffsets.put(new KafkaTopicPartition(TOPIC, PARTITION_1), OFFSET_1);
+
+ final DecodingFormat<DeserializationSchema<RowData>> valueDecodingFormat =
+ new DecodingFormatMock(",", true);
+
+ // Test scan source equals
+ final KafkaDynamicSource expectedKafkaSource =
+ createExpectedScanSource(
+ SCHEMA_DATA_TYPE,
+ null,
+ valueDecodingFormat,
+ new int[0],
+ new int[] {0, 1, 2},
+ null,
+ Collections.singletonList(TOPIC),
+ null,
+ KAFKA_SOURCE_PROPERTIES,
+ StartupMode.SPECIFIC_OFFSETS,
+ specificOffsets,
+ 0,
+ 100);
+ assertThat(actualKafkaSource).isEqualTo(expectedKafkaSource);
+
+ ScanTableSource.ScanRuntimeProvider provider =
+ actualKafkaSource.getScanRuntimeProvider(ScanRuntimeProviderContext.INSTANCE);
+ assertThat(provider).isInstanceOf(DataStreamScanProvider.class);
+ final DataStreamScanProvider sourceProvider = (DataStreamScanProvider) provider;
+ assertThat(sourceProvider.getParallelism().isPresent()).isTrue();
+ assertThat(sourceProvider.getParallelism().get()).isEqualTo(100);
Review Comment:
```suggestion
assertThat(sourceProvider.getParallelism()).isPresent;
assertThat(sourceProvider.getParallelism()).hasValue(100);
```
##########
flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicTableFactoryTest.java:
##########
@@ -212,14 +212,56 @@ public void testTableSource() {
KAFKA_SOURCE_PROPERTIES,
StartupMode.SPECIFIC_OFFSETS,
specificOffsets,
- 0);
+ 0,
+ null);
assertThat(actualKafkaSource).isEqualTo(expectedKafkaSource);
ScanTableSource.ScanRuntimeProvider provider =
actualKafkaSource.getScanRuntimeProvider(ScanRuntimeProviderContext.INSTANCE);
assertKafkaSource(provider);
}
+ @Test
+ public void testTableSourceWithParallelism() {
+ final Map<String, String> modifiedOptions =
+ getModifiedOptions(
+ getBasicSourceOptions(), options -> options.put("scan.parallelism", "100"));
+ final DynamicTableSource actualSource = createTableSource(SCHEMA, modifiedOptions);
+ final KafkaDynamicSource actualKafkaSource = (KafkaDynamicSource) actualSource;
+
+ final Map<KafkaTopicPartition, Long> specificOffsets = new HashMap<>();
+ specificOffsets.put(new KafkaTopicPartition(TOPIC, PARTITION_0), OFFSET_0);
+ specificOffsets.put(new KafkaTopicPartition(TOPIC, PARTITION_1), OFFSET_1);
+
+ final DecodingFormat<DeserializationSchema<RowData>> valueDecodingFormat =
+ new DecodingFormatMock(",", true);
+
+ // Test scan source equals
+ final KafkaDynamicSource expectedKafkaSource =
+ createExpectedScanSource(
+ SCHEMA_DATA_TYPE,
+ null,
+ valueDecodingFormat,
+ new int[0],
+ new int[] {0, 1, 2},
+ null,
+ Collections.singletonList(TOPIC),
+ null,
+ KAFKA_SOURCE_PROPERTIES,
+ StartupMode.SPECIFIC_OFFSETS,
+ specificOffsets,
+ 0,
+ 100);
+ assertThat(actualKafkaSource).isEqualTo(expectedKafkaSource);
+
+ ScanTableSource.ScanRuntimeProvider provider =
+ actualKafkaSource.getScanRuntimeProvider(ScanRuntimeProviderContext.INSTANCE);
+ assertThat(provider).isInstanceOf(DataStreamScanProvider.class);
+ final DataStreamScanProvider sourceProvider = (DataStreamScanProvider) provider;
+ assertThat(sourceProvider.getParallelism().isPresent()).isTrue();
+ assertThat(sourceProvider.getParallelism().get()).isEqualTo(100);
Review Comment:
```suggestion
assertThat(sourceProvider.getParallelism()).isPresent();
assertThat(sourceProvider.getParallelism()).hasValue(100);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org