You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by de...@apache.org on 2008/02/16 16:55:32 UTC

svn commit: r628332 - in /maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira: AbstractJiraDownloader.java JiraMojo.java

Author: dennisl
Date: Sat Feb 16 07:55:30 2008
New Revision: 628332

URL: http://svn.apache.org/viewvc?rev=628332&view=rev
Log:
[MCHANGES-103] Allow suffix "ASC" for sort columns
Submitted by: Benjamin Bentmann
Reviewed by: Dennis Lundberg

o I also added documentation for this in the mojo.

Modified:
    maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/AbstractJiraDownloader.java
    maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/JiraMojo.java

Modified: maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/AbstractJiraDownloader.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/AbstractJiraDownloader.java?rev=628332&r1=628331&r2=628332&view=diff
==============================================================================
--- maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/AbstractJiraDownloader.java (original)
+++ maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/AbstractJiraDownloader.java Sat Feb 16 07:55:30 2008
@@ -222,6 +222,11 @@
                     descending = true;
                     lowerColumnName = lowerColumnName.substring( 0, lowerColumnName.length() - 4 ).trim();
                 }
+                else if ( lowerColumnName.endsWith( "asc" ) )
+                {
+                    descending = false;
+                    lowerColumnName = lowerColumnName.substring( 0, lowerColumnName.length() - 3 ).trim();
+                }
 
                 if ( "key".equals( lowerColumnName ) )
                 {

Modified: maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/JiraMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/JiraMojo.java?rev=628332&r1=628331&r2=628332&view=diff
==============================================================================
--- maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/JiraMojo.java (original)
+++ maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/JiraMojo.java Sat Feb 16 07:55:30 2008
@@ -170,7 +170,9 @@
      * to specify <i>descending</i> sequence. For
      * example <code>Fix Version DESC, Type</code> sorts first by
      * the Fix Version in descending order and then by Type in
-     * ascending order.
+     * ascending order. By default sorting is done in ascending order, but is
+     * possible to specify <code>ASC</code> for consistency. The previous
+     * example would then become <code>Fix Version DESC, Type ASC</code>. 
      * <p>
      * Valid columns are: <code>Key</code>, <code>Summary</code>,
      * <code>Status</code>, <code>Resolution</code>, <code>Assignee</code>,