You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by dawidwys <gi...@git.apache.org> on 2018/06/19 14:20:31 UTC

[GitHub] flink pull request #6182: [FLINK-8795] Fixed local scala shell for Flip6

GitHub user dawidwys opened a pull request:

    https://github.com/apache/flink/pull/6182

    [FLINK-8795] Fixed local scala shell for Flip6

    ## What is the purpose of the change
    
    Enable to run scala-shell in local mode with new runtime mode.
    
    ## Brief change log
    
    - Creating either MiniCluster or StandaloneMiniCluster based on the mode.
    
    ## Verifying this change
    
    *(Please pick either of the following options)*
    
    Changed tests to run both on new and legacy runtime.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no /** don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dawidwys/flink FLINK-8795

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6182.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6182
    
----
commit 6fa4aa18c2d111a846386fed27354bd7a1da2a0b
Author: Dawid Wysakowicz <dw...@...>
Date:   2018-06-19T07:49:31Z

    [FLINK-8795] Fixed local scala shell for Flip6

----


---

[GitHub] flink issue #6182: [FLINK-8795] Fixed local scala shell for Flip6

Posted by tzulitai <gi...@git.apache.org>.

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/6182
  
    Merging this ..


---

[GitHub] flink pull request #6182: [FLINK-8795] Fixed local scala shell for Flip6

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/6182


---

[GitHub] flink issue #6182: [FLINK-8795] Fixed local scala shell for Flip6

Posted by tzulitai <gi...@git.apache.org>.

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/6182
  
    Thanks for the fix @dawidwys!
    The changes LGTM on my side, +1.


---