You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/25 19:39:58 UTC
[GitHub] [beam] pabloem commented on a change in pull request #11227:
[BEAM-9601] Skip the streaming wordcount test because it uses a
Python3.5.3+ feature
pabloem commented on a change in pull request #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature
URL: https://github.com/apache/beam/pull/11227#discussion_r398120887
##########
File path: sdks/python/apache_beam/runners/interactive/interactive_runner_test.py
##########
@@ -150,9 +151,10 @@ def process(self, element):
]
self.assertEqual(actual_reified, expected_reified)
+ @unittest.skipIf(
+ sys.version_info < (3, 6),
+ 'InteractiveRunner has a minimum Python version of 3.5.3.')
Review comment:
should we skip if sys.version_info < 3,5,3? so we'll test on 3.5 if it's the right subversion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services