[GitHub] [spark] WeichenXu123 commented on a change in pull request #25235: [SPARK-28483][Core] Fix canceling a spark job using barrier mode but barrier tasks do not exit

[GitBox <gi...@apache.org>]

WeichenXu123 commented on a change in pull request #25235: [SPARK-28483][Core] Fix canceling a spark job using barrier mode but barrier tasks do not exit
URL: https://github.com/apache/spark/pull/25235#discussion_r307563900
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/rpc/RpcEndpointRef.scala
 ##########
 @@ -92,4 +92,18 @@ private[spark] abstract class RpcEndpointRef(conf: SparkConf)
     timeout.awaitResult(future)
   }
 
+  def askSyncWithInterruptCheck[T: ClassTag](
 
 Review comment:
   @xuanyuanking  I found an issue. If we check this outside the RPC request `Future`, we have no way to close RPC connection when it is killed. So see my PR latest update.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org