You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/30 21:25:56 UTC
[GitHub] [airflow] potiuk opened a new pull request, #27390: Fix passing of "github_repository" when running shell command in breeze
potiuk opened a new pull request, #27390:
URL: https://github.com/apache/airflow/pull/27390
When running "shell" commands for another repository, the github_repository was not passed to the command that checks for image availability and pulls the image if missing. This only was a problem on CI when migrations were run with target to another repository - migration jobs were waiting for "apache/airflow" tagged image, and they shoudl wait for "other_repo/airflow".
This PR fixes it.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #27390: Fix passing of "github_repository" when running shell command in breeze
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #27390:
URL: https://github.com/apache/airflow/pull/27390#issuecomment-1296354685
Another missing place where github_repository was not passed - found during refactoring of CI yaml files with composite actions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #27390: Fix passing of "github_repository" when running shell command in breeze
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #27390:
URL: https://github.com/apache/airflow/pull/27390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #27390: Fix passing of "github_repository" when running shell command in breeze
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #27390:
URL: https://github.com/apache/airflow/pull/27390#issuecomment-1296354824
Not critical, but single-liner worth fixing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org