You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/01 19:38:30 UTC
[GitHub] [airflow] XD-DENG opened a new pull request #12746: Move config item 'worker_precheck' from section [core] to [celery]
XD-DENG opened a new pull request #12746:
URL: https://github.com/apache/airflow/pull/12746
This configuration is ONLY applicable for Celery Worker. So it should be in section `[celery]`, rather than `[core]`.
No logic change in this PR.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #12746: Move config item 'worker_precheck' from section [core] to [celery]
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #12746:
URL: https://github.com/apache/airflow/pull/12746#issuecomment-736779080
> Can you look at the config deprecation mechansims we already have (look at logging for instance) and see if you can add this to the deprecation/migration automatic list.
Good point! Thanks for it.
Done in https://github.com/apache/airflow/pull/12746/commits/e18db792fb386112855e3949193b65747ebc5b76
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12746: Move config item 'worker_precheck' from section [core] to [celery]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12746:
URL: https://github.com/apache/airflow/pull/12746#issuecomment-736849519
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG merged pull request #12746: Move config item 'worker_precheck' from section [core] to [celery]
Posted by GitBox <gi...@apache.org>.
XD-DENG merged pull request #12746:
URL: https://github.com/apache/airflow/pull/12746
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org