You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/10/02 00:24:25 UTC
[GitHub] [druid] clintropolis opened a new pull request #10460: fix array types from escaping into wider query engine
clintropolis opened a new pull request #10460:
URL: https://github.com/apache/druid/pull/10460
### Description
This PR fixes an issue caused by #9638 being a bit over-ambitious and wiring up calcite arrays to druid array types, which resulted in array types leaking into the rest of the query engine.
It also fixes an bug where expressions with explicitly array typed output could incorrectly set `ExpressionPlan.Trait.SINGLE_INPUT_MAPPABLE` resulting in an incorrect dimension selector being used.
<hr>
This PR has:
- [x] been self-reviewed.
- [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] lgtm-com[bot] commented on pull request #10460: fix array types from escaping into wider query engine
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #10460:
URL: https://github.com/apache/druid/pull/10460#issuecomment-702481303
This pull request **introduces 1 alert** when merging dd97e531585fa427dfd3c22cf1b697c7150d3cbe into 7385af027250440ff66573789fc0543ee056777f - [view on LGTM.com](https://lgtm.com/projects/g/apache/druid/rev/pr-09c22ff7c0595a5fae6dc8a20bacda5413a5b3c6)
**new alerts:**
* 1 for Useless null check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jon-wei merged pull request #10460: fix array types from escaping into wider query engine
Posted by GitBox <gi...@apache.org>.
jon-wei merged pull request #10460:
URL: https://github.com/apache/druid/pull/10460
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org