[GitHub] [spark] LuciferYang commented on a change in pull request #34758: [SPARK-37501][SQL] CREATE/REPLACE TABLE should qualify location for v2 command

[GitBox <gi...@apache.org>]

LuciferYang commented on a change in pull request #34758:
URL: https://github.com/apache/spark/pull/34758#discussion_r759828620



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -95,10 +95,13 @@ class DataSourceV2Strategy(session: SparkSession) extends Strategy with Predicat
   }
 
   private def makeQualifiedNamespacePath(location: String): String = {
-    val warehousePath = session.sharedState.conf.get(WAREHOUSE_PATH)
-    val nsPath = CatalogUtils.makeQualifiedNamespacePath(
-      CatalogUtils.stringToURI(location), warehousePath, session.sharedState.hadoopConf)
-    CatalogUtils.URIToString(nsPath)
+    CatalogUtils.makeQualifiedLocationPath(session.sharedState.conf.get(WAREHOUSE_PATH),

Review comment:
       should we use a more generic method name and merge `makeQualifiedNamespacePath` and `makeQualifiedTablePath`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org