You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/12/28 08:20:54 UTC
[GitHub] [orc] georgthegreat opened a new pull request #980: Stabilize HAS_POST_2038 test
georgthegreat opened a new pull request #980:
URL: https://github.com/apache/orc/pull/980
On my machine (Ubuntu Bionic, libc6=2.31-0ubuntu9.2, tzdata=2021e-0ubuntu0.20.04) the following results are returned by strptime:
```
time2037.tm_hour = 13; // weird
time2038.tm_hour = 12; // correct
```
This results in time difference 31532400 (which is 3600 less than expected). Some other configurations give the expected result, thus making the build variable to flap during sequential builds on different systems.
Since this is just a basic test, I suggest relaxing it a bit in order to make it stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac commented on pull request #980: ORC-1068: [C++] Stabilize HAS_POST_2038 test
Posted by GitBox <gi...@apache.org>.
wgtmac commented on pull request #980:
URL: https://github.com/apache/orc/pull/980#issuecomment-1002152506
> How to I link Jira issue to GitHub PR?
I have linked this PR to the JIRA your have created. Usually if you put the issue number in the title, it will automatically be linked to the JIRA issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #980: ORC-1068: [C++] Stabilize HAS_POST_2038 test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #980:
URL: https://github.com/apache/orc/pull/980#issuecomment-1002763140
@georgthegreat I added you to the Apache ORC contributor group and assigned ORC-1068 to you. Thank you again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] georgthegreat edited a comment on pull request #980: ORC-1068: [C++] Stabilize HAS_POST_2038 test
Posted by GitBox <gi...@apache.org>.
georgthegreat edited a comment on pull request #980:
URL: https://github.com/apache/orc/pull/980#issuecomment-1002769226
Thank you, Dongjoon!
I'll check it when 1.7.3 will be released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] georgthegreat commented on pull request #980: Stabilize HAS_POST_2038 test
Posted by GitBox <gi...@apache.org>.
georgthegreat commented on pull request #980:
URL: https://github.com/apache/orc/pull/980#issuecomment-1002143280
How to I link Jira issue to GitHub PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #980: ORC-1068: [C++] Stabilize HAS_POST_2038 test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #980:
URL: https://github.com/apache/orc/pull/980#discussion_r776225445
##########
File path: c++/src/CMakeLists.txt
##########
@@ -157,7 +157,7 @@ CHECK_CXX_SOURCE_RUNS("
struct tm time2038;
strptime(\"2037-05-05 12:34:56\", \"%Y-%m-%d %H:%M:%S\", &time2037);
strptime(\"2038-05-05 12:34:56\", \"%Y-%m-%d %H:%M:%S\", &time2038);
- return mktime(&time2038) - mktime(&time2037) != 31536000;
+ return (mktime(&time2038) - mktime(&time2037)) <= 31500000;
Review comment:
Does this fail on a system who has YEAR 2038 problem? I'm wondering if `(mktime(&time2038) - mktime(&time2037))` becomes negative and satisfies `<= 31500000` condition even in that system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #980: ORC-1068: [C++] Stabilize HAS_POST_2038 test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #980:
URL: https://github.com/apache/orc/pull/980#issuecomment-1002761963
I cherry-picked this to branch-1.7 too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac commented on pull request #980: Stabilize HAS_POST_2038 test
Posted by GitBox <gi...@apache.org>.
wgtmac commented on pull request #980:
URL: https://github.com/apache/orc/pull/980#issuecomment-1002135786
@georgthegreat Thanks for your first contribution! Can you create a JIRA [here](https://issues.apache.org/jira/secure/CreateIssue!default.jspa) and associate it with the pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] georgthegreat commented on pull request #980: ORC-1068: [C++] Stabilize HAS_POST_2038 test
Posted by GitBox <gi...@apache.org>.
georgthegreat commented on pull request #980:
URL: https://github.com/apache/orc/pull/980#issuecomment-1002769226
Thank you, Dongjoon!
I'll test it when 1.7.3 will be released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #980: ORC-1068: [C++] Stabilize HAS_POST_2038 test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #980:
URL: https://github.com/apache/orc/pull/980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] georgthegreat edited a comment on pull request #980: Stabilize HAS_POST_2038 test
Posted by GitBox <gi...@apache.org>.
georgthegreat edited a comment on pull request #980:
URL: https://github.com/apache/orc/pull/980#issuecomment-1002142884
@wgtmac, thanks for the response.
I have flagged [ORC-1068](https://issues.apache.org/jira/browse/ORC-1068) by simply copying some information from the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] georgthegreat commented on pull request #980: Stabilize HAS_POST_2038 test
Posted by GitBox <gi...@apache.org>.
georgthegreat commented on pull request #980:
URL: https://github.com/apache/orc/pull/980#issuecomment-1002142884
@wgtmac, thanks for the response.
I have flagged [ORC-1068](https://issues.apache.org/jira/browse/ORC-1068) by simply copying some information from the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #980: ORC-1068: [C++] Stabilize HAS_POST_2038 test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #980:
URL: https://github.com/apache/orc/pull/980#discussion_r776225445
##########
File path: c++/src/CMakeLists.txt
##########
@@ -157,7 +157,7 @@ CHECK_CXX_SOURCE_RUNS("
struct tm time2038;
strptime(\"2037-05-05 12:34:56\", \"%Y-%m-%d %H:%M:%S\", &time2037);
strptime(\"2038-05-05 12:34:56\", \"%Y-%m-%d %H:%M:%S\", &time2038);
- return mktime(&time2038) - mktime(&time2037) != 31536000;
+ return (mktime(&time2038) - mktime(&time2037)) <= 31500000;
Review comment:
Just a question. Does this fail on a system who has YEAR 2038 problem? I'm wondering if `(mktime(&time2038) - mktime(&time2037))` becomes negative and satisfies `<= 31500000` condition even in that system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org