[jira] [Commented] (SPARK-2220) Fix remaining Hive Commands

["Cheng Lian (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14191841#comment-14191841 ] 

Cheng Lian commented on SPARK-2220:
-----------------------------------

It turned out that {{ShellCommand}} and {{SourceCommand}} are wrongly interpreted in Spark SQL previously. These two classes correspond to the {{\!}} and {{SOURCE}} syntaxes respectively in Spark SQL. However, back in Hive, {{\!}} is interpreted in different ways by Hive CLI and Beeline, and {{SOURCE}} is only supported by Hive CLI.

For {{\!}}, in Hive CLI, {{\!}} starts a shell command (e.g. {{\!ls;}} and {{\!cat foo;}}), while in Beeline {{\!}} starts a Beeline command (e.g. {{\!connect jdbc:hive://localhost:10000}} and {{\!run script.sql}}). And the {{SOURCE file}} command in Hive CLI is equivalent to the {{\!run file}} command in Beeline.

In a word, functionalities of these two commands should not be implemented in {{sql/core}} and/or {{sql/hive}}, but are already implemented as part of Spark SQL CLI and Hive Beeline.

> Fix remaining Hive Commands
> ---------------------------
>
>                 Key: SPARK-2220
>                 URL: https://issues.apache.org/jira/browse/SPARK-2220
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>            Reporter: Michael Armbrust
>            Assignee: Cheng Lian
>
> None of the following have an execution plan:
> {code}
> private[hive] case class ShellCommand(cmd: String) extends Command
> private[hive] case class SourceCommand(filePath: String) extends Command
> private[hive] case class AddFile(filePath: String) extends Command
> {code}
> dfs is being fixed in a related PR.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org