You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by lc...@apache.org on 2018/10/17 21:59:39 UTC

[beam] branch lukecwik-beam5780 created (now 4e12d67)

This is an automated email from the ASF dual-hosted git repository.

lcwik pushed a change to branch lukecwik-beam5780
in repository https://gitbox.apache.org/repos/asf/beam.git.


      at 4e12d67  [BEAM-5780] Update comment

This branch includes the following new commits:

     new 4e12d67  [BEAM-5780] Update comment

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[beam] 01/01: [BEAM-5780] Update comment

Posted by lc...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

lcwik pushed a commit to branch lukecwik-beam5780
in repository https://gitbox.apache.org/repos/asf/beam.git

commit 4e12d672082520331258a1f47de31087821bdf8d
Author: Lukasz Cwik <lc...@google.com>
AuthorDate: Wed Oct 17 14:59:29 2018 -0700

    [BEAM-5780] Update comment
---
 .../worker/legacy-worker/build.gradle                          | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/runners/google-cloud-dataflow-java/worker/legacy-worker/build.gradle b/runners/google-cloud-dataflow-java/worker/legacy-worker/build.gradle
index 3b45dd0..a423444 100644
--- a/runners/google-cloud-dataflow-java/worker/legacy-worker/build.gradle
+++ b/runners/google-cloud-dataflow-java/worker/legacy-worker/build.gradle
@@ -17,11 +17,11 @@
  */
 
 // There is no actual src dir under legacy-worker/ since legacy-worker is built against the
-// same sourceSets as fn-api-worker. The reason why legacy-worker has a separated dir is:
-// 1. Instead of point both legacy-worker and fn-api-worker project to the same worker/,
-// make them point to different dirs.
-// 2. Make built artifacts and test reports go to worker/build for fn-api-worker and
-// legacy-worker/build for legacy worker.
+// same sourceSet as fn-api-worker. The reason why legacy-worker has a separated dir is:
+// 1. Have one location for editing worker code which is built and tested in two
+//    different ways.
+// 2. Not have artifacts such as test results and jars write over each other.
+// 3. Better compatibility with Intellij since Intellij requires separate content roots.
 
 apply plugin: org.apache.beam.gradle.BeamModulePlugin