[GitHub] [flink] akalash commented on a diff in pull request #19864: [FLINK-27162][runtime] Trigger non-periodic checkpoint in 'timer' thread

[GitBox <gi...@apache.org>]

akalash commented on code in PR #19864:
URL: https://github.com/apache/flink/pull/19864#discussion_r915648538


##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/StateWithExecutionGraph.java:
##########
@@ -286,7 +286,7 @@ CompletableFuture<String> triggerCheckpoint() {
         logger.info("Triggering a checkpoint for job {}.", jobID);
 
         return checkpointCoordinator
-                .triggerCheckpoint(false)
+                .triggerCheckpointFromCheckpointThread(false)

Review Comment:
   I thought about that. But I was afraid of the number of tests that use the synchronous triggering checkpoints. But now, as I see, perhaps, not all of them really require synchronous checkpoint. So I will take a look at how is difficult to change another tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org