You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Alejandro Abdelnur <tu...@cloudera.com> on 2012/05/11 15:43:19 UTC
Review Request: OOZIE-835 XTestCase Minicluster hangs when shutting down
with an exception using Hadoop 2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5093/
-----------------------------------------------------------
Review request for oozie.
Summary
-------
Instead using a shutdownhook, the patch uses a monitor thread that detects that no testcase is running for X seconds and then triggers a shutdown of the minicluster
This addresses bug OOZIE-835.
https://issues.apache.org/jira/browse/OOZIE-835
Diffs
-----
trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1337157
Diff: https://reviews.apache.org/r/5093/diff
Testing
-------
run all testcases with hadoop 1 and hadoop 2 and test JVM shutdown properly
Thanks,
Alejandro
Re: Review Request: OOZIE-835 XTestCase Minicluster hangs when shutting down
with an exception using Hadoop 2
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5093/#review7810
-----------------------------------------------------------
trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java
<https://reviews.apache.org/r/5093/#comment17145>
can we create a variable for 10 second ? use variable in place of hard-coded number here.
- Mohammad
On 2012-05-11 13:43:19, Alejandro Abdelnur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5093/
> -----------------------------------------------------------
>
> (Updated 2012-05-11 13:43:19)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> Instead using a shutdownhook, the patch uses a monitor thread that detects that no testcase is running for X seconds and then triggers a shutdown of the minicluster
>
>
> This addresses bug OOZIE-835.
> https://issues.apache.org/jira/browse/OOZIE-835
>
>
> Diffs
> -----
>
> trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1337157
>
> Diff: https://reviews.apache.org/r/5093/diff
>
>
> Testing
> -------
>
> run all testcases with hadoop 1 and hadoop 2 and test JVM shutdown properly
>
>
> Thanks,
>
> Alejandro
>
>
Re: Review Request: OOZIE-835 XTestCase Minicluster hangs when shutting down
with an exception using Hadoop 2
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5093/#review7811
-----------------------------------------------------------
Ship it!
+1
- Mohammad
On 2012-05-11 19:27:34, Alejandro Abdelnur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5093/
> -----------------------------------------------------------
>
> (Updated 2012-05-11 19:27:34)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> Instead using a shutdownhook, the patch uses a monitor thread that detects that no testcase is running for X seconds and then triggers a shutdown of the minicluster
>
>
> This addresses bug OOZIE-835.
> https://issues.apache.org/jira/browse/OOZIE-835
>
>
> Diffs
> -----
>
> trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1337157
>
> Diff: https://reviews.apache.org/r/5093/diff
>
>
> Testing
> -------
>
> run all testcases with hadoop 1 and hadoop 2 and test JVM shutdown properly
>
>
> Thanks,
>
> Alejandro
>
>
Re: Review Request: OOZIE-835 XTestCase Minicluster hangs when shutting down
with an exception using Hadoop 2
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5093/
-----------------------------------------------------------
(Updated 2012-05-11 19:27:34.298659)
Review request for oozie.
Changes
-------
Per Mohammad's suggestion, adding a system property that can modify the shutdown wait time of the monitor, defaulting to 10 seconds.
Per (IM) Virag's suggestion, the setupEmbeddedHadoop() minicluster initialization is try/catch and a shutdown is issued if an initialization error occurs.
Summary
-------
Instead using a shutdownhook, the patch uses a monitor thread that detects that no testcase is running for X seconds and then triggers a shutdown of the minicluster
This addresses bug OOZIE-835.
https://issues.apache.org/jira/browse/OOZIE-835
Diffs (updated)
-----
trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1337157
Diff: https://reviews.apache.org/r/5093/diff
Testing
-------
run all testcases with hadoop 1 and hadoop 2 and test JVM shutdown properly
Thanks,
Alejandro