You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/18 11:10:47 UTC

[GitHub] [apisix-dashboard] tokers commented on a change in pull request #1324: feat: pass context for `Get` and `List`

tokers commented on a change in pull request #1324:
URL: https://github.com/apache/apisix-dashboard/pull/1324#discussion_r559488674



##########
File path: api/internal/core/store/store.go
##########
@@ -136,8 +136,9 @@ func (s *GenericStore) Init() error {
 	return nil
 }
 
-func (s *GenericStore) Get(key string) (interface{}, error) {
+func (s *GenericStore) Get(ctx context.Context, key string) (interface{}, error) {
 	ret, ok := s.cache.Load(key)
+	_ = ctx

Review comment:
       If `ctx` is not in use, just use dummy variable when define the function argument.

##########
File path: api/internal/core/store/store.go
##########
@@ -173,8 +174,9 @@ var defLessFunc = func(i, j interface{}) bool {
 	return iID < jID
 }
 
-func (s *GenericStore) List(input ListInput) (*ListOutput, error) {
+func (s *GenericStore) List(ctx context.Context, input ListInput) (*ListOutput, error) {
 	var ret []interface{}
+	_ = ctx

Review comment:
       Ditto.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org