You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/06 04:53:06 UTC
[GitHub] [nuttx] Gary-Hobson opened a new pull request, #8043: drivers/note: remove choice in Kconfig
Gary-Hobson opened a new pull request, #8043:
URL: https://github.com/apache/nuttx/pull/8043
## Summary
remove choice in Kconfigļ¼ to support multiple note drivers to be used at the same time
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] Gary-Hobson commented on a diff in pull request #8043: drivers/note: remove choice in Kconfig
Posted by GitBox <gi...@apache.org>.
Gary-Hobson commented on code in PR #8043:
URL: https://github.com/apache/nuttx/pull/8043#discussion_r1063129329
##########
drivers/note/Kconfig:
##########
@@ -195,12 +180,9 @@ config DRIVER_NOTECTL
If this option is selected, the instrumentation filter control device
/dev/notectl is provided.
-choice
- prompt "Note driver selection"
- default DRIVER_NOTERAM
-
config DRIVER_NOTERAM
bool "Note RAM driver"
+ default y
Review Comment:
DRIVER_NOTE is off by default
We should enable at least one note driver after enabling DRIVER_NOTE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8043: drivers/note: remove choice in Kconfig
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #8043:
URL: https://github.com/apache/nuttx/pull/8043
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8043: drivers/note: remove choice in Kconfig
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8043:
URL: https://github.com/apache/nuttx/pull/8043#discussion_r1063123104
##########
drivers/note/Kconfig:
##########
@@ -226,21 +208,32 @@ config DRIVER_NOTERAM
sched_note_get() causes several additional entries to be added from
the note buffer in order to remove one entry.
-config DRIVER_NOTEARCH
- bool "Note Arch driver"
+if DRIVER_NOTERAM
+
+config DRIVER_NOTERAM_BUFSIZE
+ int "Note RAM buffer size"
+ default 2048
---help---
- The note driver is provided by arch specific code.
+ The size of the in-memory, circular instrumentation buffer (in bytes).
+
+config DRIVER_NOTERAM_DEFAULT_NOOVERWRITE
+ bool "Disable overwrite by default"
+ default n
+ ---help---
+ Disables overwriting old notes in the circular buffer when the buffer
+ is full by default. This is useful to keep instrumentation data of the
+ beginning of a system boot.
+
+endif
config DRIVER_NOTELOG
bool "Note syslog driver"
- select SCHED_INSTRUMENTATION_EXTERNAL
---help---
The note driver output to syslog.
config SEGGER_SYSVIEW
Review Comment:
move to segger/Kconfig
##########
drivers/note/Kconfig:
##########
@@ -195,12 +180,9 @@ config DRIVER_NOTECTL
If this option is selected, the instrumentation filter control device
/dev/notectl is provided.
-choice
- prompt "Note driver selection"
- default DRIVER_NOTERAM
-
config DRIVER_NOTERAM
bool "Note RAM driver"
+ default y
Review Comment:
let's keep the default off
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] Gary-Hobson commented on a diff in pull request #8043: drivers/note: remove choice in Kconfig
Posted by GitBox <gi...@apache.org>.
Gary-Hobson commented on code in PR #8043:
URL: https://github.com/apache/nuttx/pull/8043#discussion_r1063131989
##########
drivers/note/Kconfig:
##########
@@ -226,21 +208,32 @@ config DRIVER_NOTERAM
sched_note_get() causes several additional entries to be added from
the note buffer in order to remove one entry.
-config DRIVER_NOTEARCH
- bool "Note Arch driver"
+if DRIVER_NOTERAM
+
+config DRIVER_NOTERAM_BUFSIZE
+ int "Note RAM buffer size"
+ default 2048
---help---
- The note driver is provided by arch specific code.
+ The size of the in-memory, circular instrumentation buffer (in bytes).
+
+config DRIVER_NOTERAM_DEFAULT_NOOVERWRITE
+ bool "Disable overwrite by default"
+ default n
+ ---help---
+ Disables overwriting old notes in the circular buffer when the buffer
+ is full by default. This is useful to keep instrumentation data of the
+ beginning of a system boot.
+
+endif
config DRIVER_NOTELOG
bool "Note syslog driver"
- select SCHED_INSTRUMENTATION_EXTERNAL
---help---
The note driver output to syslog.
config SEGGER_SYSVIEW
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8043: drivers/note: remove choice in Kconfig
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8043:
URL: https://github.com/apache/nuttx/pull/8043#discussion_r1063148283
##########
drivers/note/Kconfig:
##########
@@ -195,12 +180,9 @@ config DRIVER_NOTECTL
If this option is selected, the instrumentation filter control device
/dev/notectl is provided.
-choice
- prompt "Note driver selection"
- default DRIVER_NOTERAM
-
config DRIVER_NOTERAM
bool "Note RAM driver"
+ default y
Review Comment:
Ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org