You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/19 15:50:41 UTC

[GitHub] [spark] srowen commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

srowen commented on pull request #28710:
URL: https://github.com/apache/spark/pull/28710#issuecomment-646707991


   Just catching up here: so all the MiMa excludes don't actually represent public API changes right? they're all sealed or private? 
   We're going to lose the `@Since` annotations, which is a little unfortunate, but I can see the value in refactoring


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org