You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/29 14:23:01 UTC
[GitHub] [pulsar] lhotari opened a new pull request #10442: [Docs] Add instructions for building custom docker images
lhotari opened a new pull request #10442:
URL: https://github.com/apache/pulsar/pull/10442
### Motivation & Modifications
Adds instructions for building custom docker images to README.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #10442: [Docs] Add instructions for building custom docker images
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #10442:
URL: https://github.com/apache/pulsar/pull/10442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10442: [Docs] Add instructions for building custom docker images
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #10442:
URL: https://github.com/apache/pulsar/pull/10442#discussion_r623512296
##########
File path: README.md
##########
@@ -129,6 +129,39 @@ $ bin/pulsar standalone
Check https://pulsar.apache.org for documentation and examples.
+## Building custom docker images
+
+Docker images must be built with Java 8 for `branch-2.7` or previous branches because of
+[issue 8445](https://github.com/apache/pulsar/issues/8445).
+This issue has been resolved in the `master` branch (and will be part of `branch-2.8`).
+It is recommended to use Java 8 until Java 11 support has been finished
+([issue 9578](https://github.com/apache/pulsar/issues/9578)).
+
+This builds the docker images `apachepulsar/pulsar-all:latest` and `apachepulsar/pulsar:latest`.
+
+```bash
+# make sure to build with Java 8 since building with newer versions isn't yet supported
+java -version
+mvn clean install -DskipTests
+mvn package -Pdocker,-main -am -pl docker/pulsar-all -DskipTests
+```
+
+After building the images can be tagged and pushed to some custom repository.
Review comment:
```suggestion
After the images are built, they can be tagged and pushed to your custom repository.
```
##########
File path: README.md
##########
@@ -129,6 +129,39 @@ $ bin/pulsar standalone
Check https://pulsar.apache.org for documentation and examples.
+## Building custom docker images
Review comment:
```suggestion
## Build custom docker images
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #10442: [Docs] Add instructions for building custom docker images
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #10442:
URL: https://github.com/apache/pulsar/pull/10442#issuecomment-829866804
@lhotari thanks for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10442: [Docs] Add instructions for building custom docker images
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10442:
URL: https://github.com/apache/pulsar/pull/10442#issuecomment-829280896
@Anonymitaet @Huanli-Meng Please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10442: [Docs] Add instructions for building custom docker images
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10442:
URL: https://github.com/apache/pulsar/pull/10442#issuecomment-829443029
@eolivelli Please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org