You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Neil C Smith <ne...@googlemail.com> on 2017/09/29 10:04:19 UTC
Form editor license support Re: [mentors] Review of Modules Review
On Fri, Sep 29, 2017 at 10:51 AM Geertjan Wielenga <
geertjan.wielenga@googlemail.com> wrote:
> Since we can generate the headers into the form files, and Jan Lahoda has
> already done this via the tool, why not accept them into the Apache
> NetBeans source code? Indeed, one of the highest priorities after the first
> incubator release should be to generate those automatically into newly
> created form files from the GUI Builder.
>
>
Changed subject as requested ...
Not disagreeing the need to support this and following the Apache way.
Just wondered if there are risks to doing this manually before making the
changes to NetBeans to support this? I guess not an issue if the form
editor ignores headers completely? And the chances of changes being
required and needing to watch for the headers being removed is minor?
Best wishes,
Neil
--
Neil C Smith
Artist & Technologist
www.neilcsmith.net
Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org
Re: Form editor license support Re: [mentors] Review of Modules Review
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Fri, Sep 29, 2017 at 12:38 PM, Geertjan Wielenga
<ge...@googlemail.com> wrote:
> ...run the converter tool before each Apache
> NetBeans release to add them that way, i.e., by inserting the license
> headers automatically before each release via the tool...
I like this idea, would work for all files regardless of how they are generated.
-Bertrand
Re: Form editor license support Re: [mentors] Review of Modules Review
Posted by Neil C Smith <ne...@googlemail.com>.
On Fri, Sep 29, 2017 at 1:05 PM Geertjan Wielenga <
geertjan.wielenga@googlemail.com> wrote:
>
> And no the converter tool just looks for patterns and replaces them with
> the Apache license automatically.
>
>
I understand that. You suggested not changing the GUI Builder. My point
was that as and until the GUI Builder supports retention (ideally editing)
of license headers in .form files, I believe we have a situation where
either -
a) before any commit that affects a .form file that file will need to have
the header reinserted (from outside NB), without formatting / line break
changes, etc.
or
b) we allow .form files to be committed as edited, then run the tool prior
to release, at which point we end up with a git history where the license
is removed by the edit commit, and re-added in the tool check commit stage?
Isn't your suggestion like b) then? Ideally we'd want a) if anything.
Or is there a c) I'm misunderstanding here? :-)
Of course, checking all license headers prior to any release would still be
a good thing.
Best wishes,
Neil
--
Neil C Smith
Artist & Technologist
www.neilcsmith.net
Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org
Re: Form editor license support Re: [mentors] Review of Modules Review
Posted by Geertjan Wielenga <ge...@googlemail.com>.
Nothing you need to do, it's already been done.
And no the converter tool just looks for patterns and replaces them with
the Apache license automatically.
Gj
On Fri, 29 Sep 2017 at 14:01, Neil C Smith <ne...@googlemail.com>
wrote:
> On Fri, Sep 29, 2017 at 11:39 AM Geertjan Wielenga <
> geertjan.wielenga@googlemail.com> wrote:
>
> > A different approach might be to not change the GUI Builder to add them
> > automatically but, instead... to run the converter tool before each
> Apache
> > NetBeans release to add them that way, i.e., by inserting the license
> > headers automatically before each release via the tool. That would mean
> no
> > changes would be needed to the GUI Builder. Just an idea.
> >
> >
> Unless I'm missing something, wouldn't that lead to a load of license
> header removal and reinsertion happening in git? Part of my concern is the
> potential for a whole load of noise in the git history unless there's a
> careful eye on this until the GUI builder is fixed to support it.
>
> I'd still argue for taking the option in the issue of leaving them *for
> now*, but as someone who's very aware that I have no time for a week or two
> to get my hands dirty on any of this, that's a decision for those who can!
>
> Best wishes,
>
> Neil
>
>
> --
> Neil C Smith
> Artist & Technologist
> www.neilcsmith.net
>
> Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org
>
Re: Form editor license support Re: [mentors] Review of Modules Review
Posted by Neil C Smith <ne...@googlemail.com>.
On Fri, Sep 29, 2017 at 11:39 AM Geertjan Wielenga <
geertjan.wielenga@googlemail.com> wrote:
> A different approach might be to not change the GUI Builder to add them
> automatically but, instead... to run the converter tool before each Apache
> NetBeans release to add them that way, i.e., by inserting the license
> headers automatically before each release via the tool. That would mean no
> changes would be needed to the GUI Builder. Just an idea.
>
>
Unless I'm missing something, wouldn't that lead to a load of license
header removal and reinsertion happening in git? Part of my concern is the
potential for a whole load of noise in the git history unless there's a
careful eye on this until the GUI builder is fixed to support it.
I'd still argue for taking the option in the issue of leaving them *for
now*, but as someone who's very aware that I have no time for a week or two
to get my hands dirty on any of this, that's a decision for those who can!
Best wishes,
Neil
--
Neil C Smith
Artist & Technologist
www.neilcsmith.net
Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org
Re: Form editor license support Re: [mentors] Review of Modules Review
Posted by Geertjan Wielenga <ge...@googlemail.com>.
A different approach might be to not change the GUI Builder to add them
automatically but, instead... to run the converter tool before each Apache
NetBeans release to add them that way, i.e., by inserting the license
headers automatically before each release via the tool. That would mean no
changes would be needed to the GUI Builder. Just an idea.
Gj
On Fri, Sep 29, 2017 at 12:10 PM, Geertjan Wielenga <
geertjan.wielenga@googlemail.com> wrote:
> I believe so, yes, though jlahoda would be the best to answer this.
>
> Gj
>
> On Fri, Sep 29, 2017 at 12:04 PM, Neil C Smith <
> neilcsmith.net@googlemail.com> wrote:
>
>> On Fri, Sep 29, 2017 at 10:51 AM Geertjan Wielenga <
>> geertjan.wielenga@googlemail.com> wrote:
>>
>> > Since we can generate the headers into the form files, and Jan Lahoda
>> has
>> > already done this via the tool, why not accept them into the Apache
>> > NetBeans source code? Indeed, one of the highest priorities after the
>> first
>> > incubator release should be to generate those automatically into newly
>> > created form files from the GUI Builder.
>> >
>> >
>> Changed subject as requested ...
>>
>> Not disagreeing the need to support this and following the Apache way.
>> Just wondered if there are risks to doing this manually before making the
>> changes to NetBeans to support this? I guess not an issue if the form
>> editor ignores headers completely? And the chances of changes being
>> required and needing to watch for the headers being removed is minor?
>>
>> Best wishes,
>>
>> Neil
>>
>> --
>> Neil C Smith
>> Artist & Technologist
>> www.neilcsmith.net
>>
>> Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org
>>
>
>
Re: Form editor license support Re: [mentors] Review of Modules Review
Posted by Jan Lahoda <la...@gmail.com>.
As mentioned in the pull request, I have a prototype change for the form
module to preserve the leading comment (i.e. typically the license header).
Jan
On Fri, Sep 29, 2017 at 12:10 PM, Geertjan Wielenga <
geertjan.wielenga@googlemail.com> wrote:
> I believe so, yes, though jlahoda would be the best to answer this.
>
> Gj
>
> On Fri, Sep 29, 2017 at 12:04 PM, Neil C Smith <
> neilcsmith.net@googlemail.com> wrote:
>
> > On Fri, Sep 29, 2017 at 10:51 AM Geertjan Wielenga <
> > geertjan.wielenga@googlemail.com> wrote:
> >
> > > Since we can generate the headers into the form files, and Jan Lahoda
> has
> > > already done this via the tool, why not accept them into the Apache
> > > NetBeans source code? Indeed, one of the highest priorities after the
> > first
> > > incubator release should be to generate those automatically into newly
> > > created form files from the GUI Builder.
> > >
> > >
> > Changed subject as requested ...
> >
> > Not disagreeing the need to support this and following the Apache way.
> > Just wondered if there are risks to doing this manually before making the
> > changes to NetBeans to support this? I guess not an issue if the form
> > editor ignores headers completely? And the chances of changes being
> > required and needing to watch for the headers being removed is minor?
> >
> > Best wishes,
> >
> > Neil
> >
> > --
> > Neil C Smith
> > Artist & Technologist
> > www.neilcsmith.net
> >
> > Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org
> >
>
Re: Form editor license support Re: [mentors] Review of Modules Review
Posted by Geertjan Wielenga <ge...@googlemail.com>.
I believe so, yes, though jlahoda would be the best to answer this.
Gj
On Fri, Sep 29, 2017 at 12:04 PM, Neil C Smith <
neilcsmith.net@googlemail.com> wrote:
> On Fri, Sep 29, 2017 at 10:51 AM Geertjan Wielenga <
> geertjan.wielenga@googlemail.com> wrote:
>
> > Since we can generate the headers into the form files, and Jan Lahoda has
> > already done this via the tool, why not accept them into the Apache
> > NetBeans source code? Indeed, one of the highest priorities after the
> first
> > incubator release should be to generate those automatically into newly
> > created form files from the GUI Builder.
> >
> >
> Changed subject as requested ...
>
> Not disagreeing the need to support this and following the Apache way.
> Just wondered if there are risks to doing this manually before making the
> changes to NetBeans to support this? I guess not an issue if the form
> editor ignores headers completely? And the chances of changes being
> required and needing to watch for the headers being removed is minor?
>
> Best wishes,
>
> Neil
>
> --
> Neil C Smith
> Artist & Technologist
> www.neilcsmith.net
>
> Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org
>