You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "maxikrie (via GitHub)" <gi...@apache.org> on 2023/01/23 11:47:41 UTC

[GitHub] [nuttx] maxikrie opened a new pull request, #8219: stm32h7: add lower half timer driver

maxikrie opened a new pull request, #8219:
URL: https://github.com/apache/nuttx/pull/8219

   ## Summary
   Added lower half timer driver for STM32H7 (basically copy from STM32F7 architecture with minor modifications).
   
   ## Impact
   
   ## Testing
   Tested for timer 3 on nucleo-h743zi2 board
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] acassis commented on pull request #8219: stm32h7: add lower half timer driver

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #8219:
URL: https://github.com/apache/nuttx/pull/8219#issuecomment-1401948126

   Hi @maxikrie please squash these patches


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] maxikrie commented on pull request #8219: stm32h7: add lower half timer driver

Posted by "maxikrie (via GitHub)" <gi...@apache.org>.
maxikrie commented on PR #8219:
URL: https://github.com/apache/nuttx/pull/8219#issuecomment-1405770167

   I basically copied the arch/arm/src/stm32/stm_tim_lowerhalf.c. Without permission from the original authors,  wouldn't this violate the original license?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8219: stm32h7: add lower half timer driver

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #8219:
URL: https://github.com/apache/nuttx/pull/8219


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8219: stm32h7: add lower half timer driver

Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #8219:
URL: https://github.com/apache/nuttx/pull/8219#discussion_r1087225236


##########
arch/arm/src/stm32h7/stm32_tim_lowerhalf.c:
##########
@@ -0,0 +1,581 @@
+/****************************************************************************
+ * arch/arm/src/stm32h7/stm32_tim_lowerhalf.c
+ *
+ *   Copyright (C) 2023 Max Kriegleder. All rights reserved.
+ *   Copyright (C) 2015 Wail Khemir. All rights reserved.
+ *   Copyright (C) 2015 Omni Hoverboards Inc. All rights reserved.
+ *   Authors: Wail Khemir <kh...@gmail.com>
+ *            Paul Alexander Patience <pa...@polymtl.ca>
+ *            Max Kriegleder <ma...@gmail.com>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:

Review Comment:
   Can you contribute under Apache Software Foundation (ASF) license?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org