You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by belliraj hb <be...@gmail.com> on 2017/02/21 12:15:58 UTC
Review Request 56881: Cannot edit join node name in Workflow Manager
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56881/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav Kulshreshtha.
Bugs: AMBARI-20093
https://issues.apache.org/jira/browse/AMBARI-20093
Repository: ambari
Description
-------
Editing join node is now enabled by making it a non static node.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js 51e0461f26
contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js 2eb01d151b
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 0356e9cab6
Diff: https://reviews.apache.org/r/56881/diff/
Testing
-------
Manual testing
Thanks,
belliraj hb
Re: Review Request 56881: Cannot edit join node name in Workflow
Manager
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56881/#review166365
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On Feb. 21, 2017, 12:15 p.m., belliraj hb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56881/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 12:15 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20093
> https://issues.apache.org/jira/browse/AMBARI-20093
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Editing join node is now enabled by making it a non static node.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js 51e0461f26
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js 2eb01d151b
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 0356e9cab6
>
> Diff: https://reviews.apache.org/r/56881/diff/
>
>
> Testing
> -------
>
> Manual testing
>
>
> Thanks,
>
> belliraj hb
>
>
Re: Review Request 56881: Cannot edit join node name in Workflow
Manager
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56881/#review166477
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Feb. 21, 2017, 12:15 p.m., belliraj hb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56881/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 12:15 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20093
> https://issues.apache.org/jira/browse/AMBARI-20093
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Editing join node is now enabled by making it a non static node.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js 51e0461f26
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js 2eb01d151b
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 0356e9cab6
>
> Diff: https://reviews.apache.org/r/56881/diff/
>
>
> Testing
> -------
>
> Manual testing
>
>
> Thanks,
>
> belliraj hb
>
>