You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2017/07/10 18:33:41 UTC

[GitHub] tinkerpop issue #663: [TINKERPOP-915]Add combined handler for Http and Webso...

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/663
  
    I'm not sure if you're done with this, but as it sits right now you didn't resolve the compilation problems (and even when you resolve those there are test failures - or maybe i didn't resolve the merges/compilation problems correctly). please run the build with integration tests to see the problems. 
    
    Also, your PR looks a little odd - the commit id is not the same as the one on your other PR. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---