You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/24 03:22:02 UTC

[GitHub] [incubator-superset] jaylindquist opened a new issue #7363: Viz validation overrides no longer being used

jaylindquist opened a new issue #7363: Viz validation overrides no longer being used
URL: https://github.com/apache/incubator-superset/issues/7363
 
 
   PR #7231 updated visualization validation to take place in the exploreReducer.js `SET_FIELD_VALUE` action. This validation does not take into account any `controlOverrides` on the visualization.
   
   Specifically, the Table viz removes any validatation from the `metrics` row control. This means attempting to create a Table with only "Not Grouped By" columns fails.
   
   
   
   ### Expected results
   
   Be able to create a Table visualization with only "Not Grouped By" columns
   
   ### Actual results
   
   Creating any Table without a "Metrics" results in an error
   
   #### Screenshots
   
   ![image](https://user-images.githubusercontent.com/222699/56630031-623caa00-6615-11e9-815a-ff969664b2a2.png)
   
   #### How to reproduce the bug
   
   1. Create a Table Visualization
   1. Delete "Group by" and "Metrics" values
   1. Add "Not Grouped By" columns
   
   ### Environment
   
   Master branch as of April 22 (commit: 845218dd88ad2fe1284dcb7427c5bff20749dc74)
   
   ### Checklist
   
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   ### Additional context
   
   n/a

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org