You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by kh...@apache.org on 2014/06/23 19:35:17 UTC
svn commit: r1604889 - in
/maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear:
./ util/
Author: khmarbaise
Date: Mon Jun 23 17:35:16 2014
New Revision: 1604889
URL: http://svn.apache.org/r1604889
Log:
- Cleaned up code
- Removed WARNINGs
- Removed unused imports
- Removed unneccesary @Suppress..
Modified:
maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/AbstractEarModule.java
maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/EarExecutionContext.java
maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/EarMojo.java
maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/EarPluginException.java
maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/UnknownArtifactTypeException.java
maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/util/EarMavenArchiver.java
maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/util/InvalidJavaEEVersion.java
Modified: maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/AbstractEarModule.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/AbstractEarModule.java?rev=1604889&r1=1604888&r2=1604889&view=diff
==============================================================================
--- maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/AbstractEarModule.java (original)
+++ maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/AbstractEarModule.java Mon Jun 23 17:35:16 2014
@@ -19,15 +19,14 @@ package org.apache.maven.plugin.ear;
* under the License.
*/
+import java.util.Set;
+
import org.apache.maven.artifact.Artifact;
import org.apache.maven.plugin.MojoFailureException;
import org.apache.maven.plugin.ear.output.FileNameMappingFactory;
-import org.apache.maven.plugin.ear.output.StandardFileNameMapping;
import org.apache.maven.plugin.ear.util.ArtifactRepository;
import org.codehaus.plexus.util.xml.XMLWriter;
-import java.util.Set;
-
/**
* A base implementation of an {@link EarModule}.
*
Modified: maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/EarExecutionContext.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/EarExecutionContext.java?rev=1604889&r1=1604888&r2=1604889&view=diff
==============================================================================
--- maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/EarExecutionContext.java (original)
+++ maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/EarExecutionContext.java Mon Jun 23 17:35:16 2014
@@ -70,6 +70,7 @@ public class EarExecutionContext
return artifactRepository;
}
+ @SuppressWarnings( "unchecked" )
private void initialize( MavenProject project, String mainArtifactId, String defaultLibBundleDir,
JbossConfiguration jbossConfiguration, String fileNameMappingName,
ArtifactTypeMappingService typeMappingService )
Modified: maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/EarMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/EarMojo.java?rev=1604889&r1=1604888&r2=1604889&view=diff
==============================================================================
--- maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/EarMojo.java (original)
+++ maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/EarMojo.java Mon Jun 23 17:35:16 2014
@@ -448,7 +448,6 @@ public class EarMojo
*/
protected String[] getExcludes()
{
- @SuppressWarnings( "unchecked" )
List<String> excludeList = new ArrayList<String>( FileUtils.getDefaultExcludesAsList() );
if ( earSourceExcludes != null && !"".equals( earSourceExcludes ) )
{
Modified: maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/EarPluginException.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/EarPluginException.java?rev=1604889&r1=1604888&r2=1604889&view=diff
==============================================================================
--- maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/EarPluginException.java (original)
+++ maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/EarPluginException.java Mon Jun 23 17:35:16 2014
@@ -29,6 +29,11 @@ public class EarPluginException
extends Exception
{
+ /**
+ *
+ */
+ private static final long serialVersionUID = -5540929953103327928L;
+
public EarPluginException()
{
}
Modified: maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/UnknownArtifactTypeException.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/UnknownArtifactTypeException.java?rev=1604889&r1=1604888&r2=1604889&view=diff
==============================================================================
--- maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/UnknownArtifactTypeException.java (original)
+++ maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/UnknownArtifactTypeException.java Mon Jun 23 17:35:16 2014
@@ -29,6 +29,11 @@ public class UnknownArtifactTypeExceptio
extends EarPluginException
{
+ /**
+ *
+ */
+ private static final long serialVersionUID = 2738931967722457793L;
+
public UnknownArtifactTypeException()
{
}
Modified: maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/util/EarMavenArchiver.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/util/EarMavenArchiver.java?rev=1604889&r1=1604888&r2=1604889&view=diff
==============================================================================
--- maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/util/EarMavenArchiver.java (original)
+++ maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/util/EarMavenArchiver.java Mon Jun 23 17:35:16 2014
@@ -114,7 +114,6 @@ public class EarMavenArchiver
{
if ( config.getManifestEntries() != null )
{
- @SuppressWarnings( "unchecked" )
final Set<String> keys = config.getManifestEntries().keySet();
for ( String key : keys )
{
Modified: maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/util/InvalidJavaEEVersion.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/util/InvalidJavaEEVersion.java?rev=1604889&r1=1604888&r2=1604889&view=diff
==============================================================================
--- maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/util/InvalidJavaEEVersion.java (original)
+++ maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/util/InvalidJavaEEVersion.java Mon Jun 23 17:35:16 2014
@@ -28,6 +28,11 @@ public class InvalidJavaEEVersion
extends MojoExecutionException
{
+ /**
+ *
+ */
+ private static final long serialVersionUID = 3189028517550801372L;
+
private final String invalidVersion;
public InvalidJavaEEVersion( String message, String invalidVersion )