You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sumit Mohanty <sm...@hortonworks.com> on 2017/01/17 22:29:26 UTC

Review Request 55647: Fix issues around modifying yarn min container size

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55647/
-----------------------------------------------------------

Review request for Ambari, Siddharth Seth and Swapan Shridhar.


Bugs: Ambari-19338
    https://issues.apache.org/jira/browse/Ambari-19338


Repository: ambari


Description
-------

Fix issues around modifying yarn min container size


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py f402f78 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py a9473ad 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 8f44e16 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py d4a301c 

Diff: https://reviews.apache.org/r/55647/diff/


Testing
-------

Ran all tests locally.

One unrelated failure.

----------------------------------------------------------------------
Ran 270 tests in 6.831s

OK
----------------------------------------------------------------------
Failed tests:
FAIL: test_upgrade_restart_eu_with_ranger (test_namenode.TestNamenode)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/smohanty/enlistments/asf-ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
    return func(*args, **keywargs)
  File "/Users/smohanty/enlistments/asf-ambari/ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py", line 1478, in test_upgrade_restart_eu_with_ranger
    self.assertTrue(setup_ranger_plugin_mock.called)
AssertionError: False is not true

----------------------------------------------------------------------
Total run:1151
Total errors:0
Total failures:1


Thanks,

Sumit Mohanty


Re: Review Request 55647: Fix issues around modifying yarn min container size

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55647/
-----------------------------------------------------------

(Updated Jan. 18, 2017, 5:03 a.m.)


Review request for Ambari, Siddharth Seth and Swapan Shridhar.


Bugs: AMBARI-19578
    https://issues.apache.org/jira/browse/AMBARI-19578


Repository: ambari


Description
-------

Fix issues around modifying yarn min container size


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py f402f78 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py a9473ad 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 8f44e16 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py d4a301c 

Diff: https://reviews.apache.org/r/55647/diff/


Testing
-------

Ran all tests locally.

One unrelated failure.

----------------------------------------------------------------------
Ran 270 tests in 6.831s

OK
----------------------------------------------------------------------
Failed tests:
FAIL: test_upgrade_restart_eu_with_ranger (test_namenode.TestNamenode)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/smohanty/enlistments/asf-ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
    return func(*args, **keywargs)
  File "/Users/smohanty/enlistments/asf-ambari/ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py", line 1478, in test_upgrade_restart_eu_with_ranger
    self.assertTrue(setup_ranger_plugin_mock.called)
AssertionError: False is not true

----------------------------------------------------------------------
Total run:1151
Total errors:0
Total failures:1


Thanks,

Sumit Mohanty


Re: Review Request 55647: Fix issues around modifying yarn min container size

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55647/#review161999
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On Jan. 17, 2017, 10:29 p.m., Sumit Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55647/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2017, 10:29 p.m.)
> 
> 
> Review request for Ambari, Siddharth Seth and Swapan Shridhar.
> 
> 
> Bugs: Ambari-19338
>     https://issues.apache.org/jira/browse/Ambari-19338
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fix issues around modifying yarn min container size
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py f402f78 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py a9473ad 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 8f44e16 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py d4a301c 
> 
> Diff: https://reviews.apache.org/r/55647/diff/
> 
> 
> Testing
> -------
> 
> Ran all tests locally.
> 
> One unrelated failure.
> 
> ----------------------------------------------------------------------
> Ran 270 tests in 6.831s
> 
> OK
> ----------------------------------------------------------------------
> Failed tests:
> FAIL: test_upgrade_restart_eu_with_ranger (test_namenode.TestNamenode)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/Users/smohanty/enlistments/asf-ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
>     return func(*args, **keywargs)
>   File "/Users/smohanty/enlistments/asf-ambari/ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py", line 1478, in test_upgrade_restart_eu_with_ranger
>     self.assertTrue(setup_ranger_plugin_mock.called)
> AssertionError: False is not true
> 
> ----------------------------------------------------------------------
> Total run:1151
> Total errors:0
> Total failures:1
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>