You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by zentol <gi...@git.apache.org> on 2017/06/26 12:53:25 UTC
[GitHub] flink-shaded pull request #2: Include minor version / remove non-existing gu...
GitHub user zentol opened a pull request:
https://github.com/apache/flink-shaded/pull/2
Include minor version / remove non-existing guava child module
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink-shaded update
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink-shaded/pull/2.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2
----
commit d99dd8c98f69c53e600618489404bd03b5c12a94
Author: zentol <ch...@apache.org>
Date: 2017-06-26T12:50:18Z
Extend version for minor version
commit 99ec784c4f5ba3813b3be6135f3e431cb5eca9d7
Author: zentol <ch...@apache.org>
Date: 2017-06-26T12:51:55Z
Remove reference to nonexisting child module
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink-shaded pull request #2: Include minor version / remove non-existing gu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink-shaded/pull/2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink-shaded pull request #2: Include minor version / remove non-existing gu...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink-shaded/pull/2#discussion_r124003439
--- Diff: pom.xml ---
@@ -30,10 +30,10 @@ under the License.
<groupId>org.apache.flink</groupId>
<artifactId>flink-shaded</artifactId>
- <version>1</version>
+ <version>1.0</version>
--- End diff --
It is more likely that we have a bugfix for a child, that's true. I felt that it would be more consistent if the "primary" version is consistent across parent and children.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink-shaded pull request #2: Include minor version / remove non-existing gu...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink-shaded/pull/2#discussion_r124001072
--- Diff: pom.xml ---
@@ -30,10 +30,10 @@ under the License.
<groupId>org.apache.flink</groupId>
<artifactId>flink-shaded</artifactId>
- <version>1</version>
+ <version>1.0</version>
--- End diff --
Whats the reasoning for using major.minor as the versioning scheme?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink-shaded issue #2: Include minor version / remove non-existing guava chi...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink-shaded/pull/2
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink-shaded pull request #2: Include minor version / remove non-existing gu...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink-shaded/pull/2#discussion_r124001438
--- Diff: pom.xml ---
@@ -30,10 +30,10 @@ under the License.
<groupId>org.apache.flink</groupId>
<artifactId>flink-shaded</artifactId>
- <version>1</version>
+ <version>1.0</version>
--- End diff --
to differentiate between versions that have changed in terms of dependencies (aka "major" versions) and versions that change bugs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink-shaded pull request #2: Include minor version / remove non-existing gu...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink-shaded/pull/2#discussion_r124002219
--- Diff: pom.xml ---
@@ -30,10 +30,10 @@ under the License.
<groupId>org.apache.flink</groupId>
<artifactId>flink-shaded</artifactId>
- <version>1</version>
+ <version>1.0</version>
--- End diff --
Mh. Okay. I wonder how often we need to address bugs using minor versions in the parent pom.
This this, we'll end up with a complicated versioning scheme for example for guava: `1.2-19.0`, "1-19.0" looks a little bit easier.
But I'm okay with merging it like this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---