You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2008/04/05 05:31:24 UTC
[jira] Created: (HBASE-564) Adding a flush file of zero entries
Adding a flush file of zero entries
-----------------------------------
Key: HBASE-564
URL: https://issues.apache.org/jira/browse/HBASE-564
Project: Hadoop HBase
Issue Type: Bug
Reporter: stack
Priority: Minor
Saw this in log in TRUNK:
{code}
[junit] 2008-04-04 20:22:40,943 DEBUG [RegionServer:0.cacheFlusher] regionserver.HStore(676): Added 1403560700/text/8075392345773720818 with 0 entries, sequence id 537, data size 0.0, file size 110.0 for 1403560700/text
{code}
I thought that we'd fixed flushing zero-entry files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-564) Adding a flush file of zero entries
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586528#action_12586528 ]
stack commented on HBASE-564:
-----------------------------
+1
> Adding a flush file of zero entries
> -----------------------------------
>
> Key: HBASE-564
> URL: https://issues.apache.org/jira/browse/HBASE-564
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.2.0
> Reporter: stack
> Assignee: Jim Kellerman
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: patch.txt
>
>
> Saw this in log in TRUNK:
> {code}
> [junit] 2008-04-04 20:22:40,943 DEBUG [RegionServer:0.cacheFlusher] regionserver.HStore(676): Added 1403560700/text/8075392345773720818 with 0 entries, sequence id 537, data size 0.0, file size 110.0 for 1403560700/text
> {code}
> I thought that we'd fixed flushing zero-entry files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-564) Adding a flush file of zero entries
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HBASE-564:
--------------------------------
Attachment: patch.txt
There were thee paths that bypassed the size checks:
- HStore.doReconstructionLog called by HStore constructor
- HStore.flushCache called by HRegion.internalFlushCache called by either HRegion.close or HRegion.flushCache
Added a check in HStore.internalFlushCache to just return if cache has zero entries.
> Adding a flush file of zero entries
> -----------------------------------
>
> Key: HBASE-564
> URL: https://issues.apache.org/jira/browse/HBASE-564
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Jim Kellerman
> Priority: Minor
> Attachments: patch.txt
>
>
> Saw this in log in TRUNK:
> {code}
> [junit] 2008-04-04 20:22:40,943 DEBUG [RegionServer:0.cacheFlusher] regionserver.HStore(676): Added 1403560700/text/8075392345773720818 with 0 entries, sequence id 537, data size 0.0, file size 110.0 for 1403560700/text
> {code}
> I thought that we'd fixed flushing zero-entry files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-564) Adding a flush file of zero entries
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HBASE-564:
--------------------------------
Resolution: Cannot Reproduce
Status: Resolved (was: Patch Available)
Committed.
> Adding a flush file of zero entries
> -----------------------------------
>
> Key: HBASE-564
> URL: https://issues.apache.org/jira/browse/HBASE-564
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.2.0
> Reporter: stack
> Assignee: Jim Kellerman
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: patch.txt
>
>
> Saw this in log in TRUNK:
> {code}
> [junit] 2008-04-04 20:22:40,943 DEBUG [RegionServer:0.cacheFlusher] regionserver.HStore(676): Added 1403560700/text/8075392345773720818 with 0 entries, sequence id 537, data size 0.0, file size 110.0 for 1403560700/text
> {code}
> I thought that we'd fixed flushing zero-entry files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-564) Adding a flush file of zero entries
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586473#action_12586473 ]
Jim Kellerman commented on HBASE-564:
-------------------------------------
It turns out that we only check for a zero memcache size at the region level. Adding a check at the HStore level will be a simple patch.
> Adding a flush file of zero entries
> -----------------------------------
>
> Key: HBASE-564
> URL: https://issues.apache.org/jira/browse/HBASE-564
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Jim Kellerman
> Priority: Minor
>
> Saw this in log in TRUNK:
> {code}
> [junit] 2008-04-04 20:22:40,943 DEBUG [RegionServer:0.cacheFlusher] regionserver.HStore(676): Added 1403560700/text/8075392345773720818 with 0 entries, sequence id 537, data size 0.0, file size 110.0 for 1403560700/text
> {code}
> I thought that we'd fixed flushing zero-entry files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-564) Adding a flush file of zero entries
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HBASE-564:
--------------------------------
Fix Version/s: 0.2.0
Affects Version/s: 0.2.0
Status: Patch Available (was: Open)
Tests pass locally, please review.
> Adding a flush file of zero entries
> -----------------------------------
>
> Key: HBASE-564
> URL: https://issues.apache.org/jira/browse/HBASE-564
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.2.0
> Reporter: stack
> Assignee: Jim Kellerman
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: patch.txt
>
>
> Saw this in log in TRUNK:
> {code}
> [junit] 2008-04-04 20:22:40,943 DEBUG [RegionServer:0.cacheFlusher] regionserver.HStore(676): Added 1403560700/text/8075392345773720818 with 0 entries, sequence id 537, data size 0.0, file size 110.0 for 1403560700/text
> {code}
> I thought that we'd fixed flushing zero-entry files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (HBASE-564) Adding a flush file of zero entries
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman reopened HBASE-564:
---------------------------------
Not sure how this got cannot reproduce status. It should be fixed.
> Adding a flush file of zero entries
> -----------------------------------
>
> Key: HBASE-564
> URL: https://issues.apache.org/jira/browse/HBASE-564
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.2.0
> Reporter: stack
> Assignee: Jim Kellerman
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: patch.txt
>
>
> Saw this in log in TRUNK:
> {code}
> [junit] 2008-04-04 20:22:40,943 DEBUG [RegionServer:0.cacheFlusher] regionserver.HStore(676): Added 1403560700/text/8075392345773720818 with 0 entries, sequence id 537, data size 0.0, file size 110.0 for 1403560700/text
> {code}
> I thought that we'd fixed flushing zero-entry files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-564) Adding a flush file of zero entries
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman resolved HBASE-564.
---------------------------------
Resolution: Fixed
Setting resolution to fixed.
> Adding a flush file of zero entries
> -----------------------------------
>
> Key: HBASE-564
> URL: https://issues.apache.org/jira/browse/HBASE-564
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.2.0
> Reporter: stack
> Assignee: Jim Kellerman
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: patch.txt
>
>
> Saw this in log in TRUNK:
> {code}
> [junit] 2008-04-04 20:22:40,943 DEBUG [RegionServer:0.cacheFlusher] regionserver.HStore(676): Added 1403560700/text/8075392345773720818 with 0 entries, sequence id 537, data size 0.0, file size 110.0 for 1403560700/text
> {code}
> I thought that we'd fixed flushing zero-entry files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HBASE-564) Adding a flush file of zero entries
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman reassigned HBASE-564:
-----------------------------------
Assignee: Jim Kellerman
> Adding a flush file of zero entries
> -----------------------------------
>
> Key: HBASE-564
> URL: https://issues.apache.org/jira/browse/HBASE-564
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Jim Kellerman
> Priority: Minor
>
> Saw this in log in TRUNK:
> {code}
> [junit] 2008-04-04 20:22:40,943 DEBUG [RegionServer:0.cacheFlusher] regionserver.HStore(676): Added 1403560700/text/8075392345773720818 with 0 entries, sequence id 537, data size 0.0, file size 110.0 for 1403560700/text
> {code}
> I thought that we'd fixed flushing zero-entry files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.