You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by "Matt Sicker (JIRA)" <ji...@apache.org> on 2017/03/08 04:03:38 UTC

[jira] [Resolved] (LOG4J2-1838) Add support for appending common suffix to each line of throwable stack trace

     [ https://issues.apache.org/jira/browse/LOG4J2-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Sicker resolved LOG4J2-1838.
---------------------------------
    Resolution: Fixed

PR merged and some documentation added to the layouts page. I noticed there are some hidden options in ThrowableFormatOptions that aren't mentioned on the layouts page, so I added a TODO.

The fix version is marked as 2.8.2 for now, but it may end up being 2.9 since I'd like to start making larger changes again. Thanks for the PR! Go ahead and close this if it's all good with you.

> Add support for appending common suffix to each line of throwable stack trace
> -----------------------------------------------------------------------------
>
>                 Key: LOG4J2-1838
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1838
>             Project: Log4j 2
>          Issue Type: New Feature
>          Components: Pattern Converters
>    Affects Versions: 2.8.1
>            Reporter: Zilong Song
>            Assignee: Matt Sicker
>              Labels: features
>             Fix For: 2.8.2
>
>
> Add support for appending common suffix to each line of throwable stack trace. The suffix can be configured by patterns just like patterns used elsewhere. 
> For example, pattern {{%xEx&#123;suffix(- %mdc&#123;key&#125;)&#125;}} will append a string generated by pattern {{-&#32;}}  and {{%mdc&#123;key&#125;}}.
> But patterns that handles throwable will be automatically ignored, because they will make the rendered result confusing. So pattern {{%xEx&#123;suffix(- %rEx%mdc&#123;key&#125;)&#125;}} has the same effect with {{%xEx&#123;suffix(- %mdc&#123;key&#125;)&#125;}}, as if the nested {{%rEx}} pattern has never appeared.
> Following is an example of the with such suffix: 
> {code:title=stack trace, with pattern "%xEx&#123;suffix(- %mdc&#123;key&#125;)&#125;" and MDC(key)="test mdc suffix"|borderStyle=solid}
> java.lang.IllegalArgumentException: IllegalArgument - test mdc suffix
> 	at org.apache.logging.log4j.core.pattern.ExtendedThrowablePatternConverterTest.testSuffixFromNormalPattern(ExtendedThrowablePatternConverterTest.java:48) [test-classes/:?] - test mdc suffix
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_91] - test mdc suffix
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_91] - test mdc suffix
> 	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_91] - test mdc suffix
> 	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:147) [idea_rt.jar:?] - test mdc suffix
> Caused by: java.lang.NullPointerException: null pointer - test mdc suffix
> 	at org.apache.logging.log4j.core.pattern.ExtendedThrowablePatternConverterTest.testSuffixFromNormalPattern(ExtendedThrowablePatternConverterTest.java:47) ~[test-classes/:?] - test mdc suffix
> 	... 27 more - test mdc suffix
> }}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org