You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@twopensource.com> on 2015/02/12 22:59:53 UTC
Review Request 30950: Add the option to make a non-hooked API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30950/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Zameer Manji.
Bugs: AURORA-1120
https://issues.apache.org/jira/browse/AURORA-1120
Repository: aurora
Description
-------
Add the option to make a non-hooked API.
Diffs
-----
src/main/python/apache/aurora/client/cli/context.py f8b289938201da1edd7d6dde2c65124b80b58adb
src/main/python/apache/aurora/client/factory.py 85a1398106a575c1b7759b904b32db6b07da7c1b
src/test/python/apache/aurora/client/BUILD c55adfe9825b77f418e41fa9a4ba43926bd991ed
src/test/python/apache/aurora/client/cli/BUILD 7319962b285b449b275196eb0c4033e963579d8e
src/test/python/apache/aurora/client/cli/test_context.py PRE-CREATION
src/test/python/apache/aurora/client/cli/util.py 12360c64a6c6f46d5b96f604c002b59d0f1a9b0e
src/test/python/apache/aurora/client/test_factory.py PRE-CREATION
src/test/python/apache/aurora/client/util.py PRE-CREATION
Diff: https://reviews.apache.org/r/30950/diff/
Testing
-------
./pants test.pytest --no-fast src/test/python/apache/aurora/client::
Thanks,
Joshua Cohen
Re: Review Request 30950: Add the option to make a non-hooked API.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30950/#review72254
-----------------------------------------------------------
Ship it!
Master (ab8fae2) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 12, 2015, 9:59 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30950/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2015, 9:59 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1120
> https://issues.apache.org/jira/browse/AURORA-1120
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add the option to make a non-hooked API.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py f8b289938201da1edd7d6dde2c65124b80b58adb
> src/main/python/apache/aurora/client/factory.py 85a1398106a575c1b7759b904b32db6b07da7c1b
> src/test/python/apache/aurora/client/BUILD c55adfe9825b77f418e41fa9a4ba43926bd991ed
> src/test/python/apache/aurora/client/cli/BUILD 7319962b285b449b275196eb0c4033e963579d8e
> src/test/python/apache/aurora/client/cli/test_context.py PRE-CREATION
> src/test/python/apache/aurora/client/cli/util.py 12360c64a6c6f46d5b96f604c002b59d0f1a9b0e
> src/test/python/apache/aurora/client/test_factory.py PRE-CREATION
> src/test/python/apache/aurora/client/util.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/30950/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast src/test/python/apache/aurora/client::
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 30950: Add the option to make a non-hooked API.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30950/#review72251
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Feb. 12, 2015, 1:59 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30950/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2015, 1:59 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1120
> https://issues.apache.org/jira/browse/AURORA-1120
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add the option to make a non-hooked API.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py f8b289938201da1edd7d6dde2c65124b80b58adb
> src/main/python/apache/aurora/client/factory.py 85a1398106a575c1b7759b904b32db6b07da7c1b
> src/test/python/apache/aurora/client/BUILD c55adfe9825b77f418e41fa9a4ba43926bd991ed
> src/test/python/apache/aurora/client/cli/BUILD 7319962b285b449b275196eb0c4033e963579d8e
> src/test/python/apache/aurora/client/cli/test_context.py PRE-CREATION
> src/test/python/apache/aurora/client/cli/util.py 12360c64a6c6f46d5b96f604c002b59d0f1a9b0e
> src/test/python/apache/aurora/client/test_factory.py PRE-CREATION
> src/test/python/apache/aurora/client/util.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/30950/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast src/test/python/apache/aurora/client::
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 30950: Add the option to make a non-hooked API.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30950/#review72265
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On Feb. 12, 2015, 9:59 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30950/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2015, 9:59 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1120
> https://issues.apache.org/jira/browse/AURORA-1120
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add the option to make a non-hooked API.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py f8b289938201da1edd7d6dde2c65124b80b58adb
> src/main/python/apache/aurora/client/factory.py 85a1398106a575c1b7759b904b32db6b07da7c1b
> src/test/python/apache/aurora/client/BUILD c55adfe9825b77f418e41fa9a4ba43926bd991ed
> src/test/python/apache/aurora/client/cli/BUILD 7319962b285b449b275196eb0c4033e963579d8e
> src/test/python/apache/aurora/client/cli/test_context.py PRE-CREATION
> src/test/python/apache/aurora/client/cli/util.py 12360c64a6c6f46d5b96f604c002b59d0f1a9b0e
> src/test/python/apache/aurora/client/test_factory.py PRE-CREATION
> src/test/python/apache/aurora/client/util.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/30950/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast src/test/python/apache/aurora/client::
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 30950: Add the option to make a non-hooked API.
Posted by Joshua Cohen <jc...@twopensource.com>.
> On Feb. 12, 2015, 10:03 p.m., Zameer Manji wrote:
> > src/test/python/apache/aurora/client/cli/util.py, line 313
> > <https://reviews.apache.org/r/30950/diff/1/?file=862321#file862321line313>
> >
> > Why don't you just use the imported values instead of declaring them here again?
Just trying to limit the scope of the changes. I didn't want to duplicate these values up at a higher level so I moved them, but I also don't want to change every test that references these values where they currently live.
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30950/#review72249
-----------------------------------------------------------
On Feb. 12, 2015, 9:59 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30950/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2015, 9:59 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1120
> https://issues.apache.org/jira/browse/AURORA-1120
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add the option to make a non-hooked API.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py f8b289938201da1edd7d6dde2c65124b80b58adb
> src/main/python/apache/aurora/client/factory.py 85a1398106a575c1b7759b904b32db6b07da7c1b
> src/test/python/apache/aurora/client/BUILD c55adfe9825b77f418e41fa9a4ba43926bd991ed
> src/test/python/apache/aurora/client/cli/BUILD 7319962b285b449b275196eb0c4033e963579d8e
> src/test/python/apache/aurora/client/cli/test_context.py PRE-CREATION
> src/test/python/apache/aurora/client/cli/util.py 12360c64a6c6f46d5b96f604c002b59d0f1a9b0e
> src/test/python/apache/aurora/client/test_factory.py PRE-CREATION
> src/test/python/apache/aurora/client/util.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/30950/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast src/test/python/apache/aurora/client::
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 30950: Add the option to make a non-hooked API.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30950/#review72249
-----------------------------------------------------------
src/test/python/apache/aurora/client/cli/util.py
<https://reviews.apache.org/r/30950/#comment118308>
Why don't you just use the imported values instead of declaring them here again?
- Zameer Manji
On Feb. 12, 2015, 1:59 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30950/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2015, 1:59 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1120
> https://issues.apache.org/jira/browse/AURORA-1120
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add the option to make a non-hooked API.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py f8b289938201da1edd7d6dde2c65124b80b58adb
> src/main/python/apache/aurora/client/factory.py 85a1398106a575c1b7759b904b32db6b07da7c1b
> src/test/python/apache/aurora/client/BUILD c55adfe9825b77f418e41fa9a4ba43926bd991ed
> src/test/python/apache/aurora/client/cli/BUILD 7319962b285b449b275196eb0c4033e963579d8e
> src/test/python/apache/aurora/client/cli/test_context.py PRE-CREATION
> src/test/python/apache/aurora/client/cli/util.py 12360c64a6c6f46d5b96f604c002b59d0f1a9b0e
> src/test/python/apache/aurora/client/test_factory.py PRE-CREATION
> src/test/python/apache/aurora/client/util.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/30950/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast src/test/python/apache/aurora/client::
>
>
> Thanks,
>
> Joshua Cohen
>
>